Details
Diff Detail
- Repository
- rCOMM Comm
- Branch
- media-release
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/input/input-state-container.react.js | ||
|---|---|---|
| 917–920 ↗ | (On Diff #45686) | Technically, now upload type should be always encrypted_{photo,video}, so we could remove the else branch and use invariant here |
It seems like we can delete commStaffCommunity and threadInfoInsideCommunity from the codebase as well. What do you think?
| web/input/input-state-container.react.js | ||
|---|---|---|
| 917–920 ↗ | (On Diff #45686) | I think that would be a good idea. It's better to get rid of this "dead code" and simplify InputStateContainer. Can you make those changes on both native and web before landing? |
| web/input/input-state-container.react.js | ||
|---|---|---|
| 917–920 ↗ | (On Diff #45686) | Sure! I'll do this |
| web/input/input-state-container.react.js | ||
|---|---|---|
| 917–920 ↗ | (On Diff #45686) | Great – just making sure you didn't miss that I requested to delete commStaffCommunity and threadInfoInsideCommunity as well |
There's now an increasingly long list of "dangling" functions/types that can be removed:
- commStaffCommunity
- threadInfoInsideCommunity
- uploadMultimedia
- MultimediaUploadExtras
Can you make sure to remove all of these before landing?
I was going to create a separate diff for removing the 'uploadMultimedia' but decided to fixup it into this one
They're all now removed in this diff
Thank you!! (Separate diff would've been fine – didn't mean to imply that it had to be in the same diff)