Page MenuHomePhabricator
Differential D13892

[native][web] Clean up dead conditions for media encryption
AcceptedPublic
Actions

Authored by bartek on Thu, Nov 7, 3:46 AM.
Tags
None
Referenced Files
F3177313: D13892.id.diff
Thu, Nov 7, 11:01 PM
F3177136: D13892.diff
Thu, Nov 7, 10:38 PM
F3176332: D13892.id.diff
Thu, Nov 7, 9:10 PM
F3174848: D13892.id45659.diff
Thu, Nov 7, 6:29 PM
F3174460: D13892.id45686.diff
Thu, Nov 7, 4:49 PM
F3173324: D13892.diff
Thu, Nov 7, 3:09 PM
F3167334: D13892.id45659.diff
Thu, Nov 7, 3:51 AM
F3167329: D13892.id.diff
Thu, Nov 7, 3:51 AM
View All 9 Files
Subscribers
tomek

Details

Reviewers
ashoat
Summary

In D13890 and D13891 some hardcoded switches were flipped, producing a dead code.
Removed unnecessary conditions and simplified code a bit.

Depends on D13891

Test Plan

Flow, eslint, test plans from D13890, D13891 to check for regressions

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D13262
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Thu, Nov 7, 3:46 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptThu, Nov 7, 3:46 AM
Harbormaster failed remote builds in B32572: Diff 45659!Thu, Nov 7, 3:53 AM
bartek updated this revision to Diff 45686.Thu, Nov 7, 4:28 AM

Commit missing line

Harbormaster completed remote builds in B32575: Diff 45686.Thu, Nov 7, 4:47 AM
bartek published this revision for review.Thu, Nov 7, 4:50 AM
bartek mentioned this in D13890: [native][web] Stop limiting media encryption to staff community.
bartek mentioned this in D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.
bartek added inline comments.
web/input/input-state-container.react.js
917–920

Technically, now upload type should be always encrypted_{photo,video}, so we could remove the else branch and use invariant here

ashoat accepted this revision.Thu, Nov 7, 5:35 AM

It seems like we can delete commStaffCommunity and threadInfoInsideCommunity from the codebase as well. What do you think?

web/input/input-state-container.react.js
917–920

I think that would be a good idea. It's better to get rid of this "dead code" and simplify InputStateContainer. Can you make those changes on both native and web before landing?

This revision is now accepted and ready to land.Thu, Nov 7, 5:35 AM
bartek added inline comments.Thu, Nov 7, 7:23 AM
web/input/input-state-container.react.js
917–920

Sure! I'll do this

ashoat added inline comments.Thu, Nov 7, 7:09 PM
web/input/input-state-container.react.js
917–920

Great – just making sure you didn't miss that I requested to delete commStaffCommunity and threadInfoInsideCommunity as well

Revision Contents
Changeset List

PathSize
native/
avatars/
5 lines
input/
58 lines
web/
avatars/
6 lines
input/
70 lines
1 line

Diff 45686

View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/avatars/avatar-hooks.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...