Page MenuHomePhabricator
Differential D13985

[keyserver/lib] Change frame image from hello world to channel image
AcceptedPublic
Actions

Authored by will on Wed, Nov 20, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 3:09 PM
Unknown Object (File)
Tue, Nov 26, 6:03 PM
Unknown Object (File)
Mon, Nov 25, 8:30 AM
Unknown Object (File)
Fri, Nov 22, 5:29 PM
Unknown Object (File)
Fri, Nov 22, 5:29 PM
Unknown Object (File)
Fri, Nov 22, 5:29 PM
Unknown Object (File)
Thu, Nov 21, 8:59 AM
Unknown Object (File)
Thu, Nov 21, 2:16 AM
Subscribers
tomek

Details

Reviewers
varun
ashoat
Summary

Currently the frame image is just the text "Hello world". As part of the first changes to the image, we're replacing the background of the image
with the farcaster channel's cover image if it exists. If it doesn't, we use the default channel image

Depends on D13971

Test Plan

Tested in the warpcast frame validator. Confirmed that the frame image displayed was just the channel cover image

Diff Detail

Repository
rCOMM Comm
Branch
wyilio/frames
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Wed, Nov 20, 8:45 PM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Nov 20, 8:45 PM
will added inline comments.Wed, Nov 20, 8:46 PM
keyserver/src/frog/frog.js
43

This is a placeholder. I plan to include the default cover image in keyserver/images, statically serve it through the Frog Hono server, and use its URL here in future diffs

Harbormaster completed remote builds in B32741: Diff 45915.Wed, Nov 20, 9:03 PM
will requested review of this revision.Wed, Nov 20, 9:03 PM
ashoat accepted this revision.Thu, Nov 21, 4:02 PM
ashoat added inline comments.
keyserver/flow-typed/npm/frog_v0.18.x.js
41

Can it actually return either Promise<FrogResponse> or FrogResponse?

keyserver/src/frog/frog.js
33–39

This seems more readable

This revision is now accepted and ready to land.Thu, Nov 21, 4:02 PM
will added a child revision: D13998: [keyserver] Add Thread Invitation box to the frame.Thu, Nov 21, 11:32 PM

Revision Contents
Changeset List

PathSize
keyserver/
flow-typed/
npm/
2 lines
src/
frog/
48 lines
lib/
types/
1 line

Diff 45915

View Options

keyserver/flow-typed/npm/frog_v0.18.x.js

Loading...
View Options

keyserver/src/frog/frog.js

Loading...
View Options

lib/types/farcaster-types.js

Loading...