[identity] Remove outdated comment from constants
ClosedPublic
Actions

Authored by bartek on Dec 3 2024, 3:36 AM.

Details

Reviewers

kamil
varun

Commits

rCOMM7877d5b11018: [identity] Remove outdated comment from constants

Summary

Noticed this comment. It applied to the very old database schema and is outdated.

Test Plan

None

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 3 2024, 3:36 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 3 2024, 3:36 AM

bartek published this revision for review.Dec 3 2024, 3:51 AM

Harbormaster completed remote builds in B32909: Diff 46170.Dec 3 2024, 3:54 AM

kamil accepted this revision.Dec 3 2024, 4:26 AM

This revision is now accepted and ready to land.Dec 3 2024, 4:26 AM

Closed by commit rCOMM7877d5b11018: [identity] Remove outdated comment from constants (authored by bartek). · Explain WhyDec 6 2024, 4:46 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7877d5b11018: [identity] Remove outdated comment from constants.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

constants.rs

36 lines

Diff 46170

View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Lines	declare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;		markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;

addInboundP2PMessage(message: InboundP2PMessage): void;		addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;		getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;		removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;

getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;		getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;

		updateMessageSearchIndex(
		originalMessageID: string,
		messageID: string,
		content: string,
		): void;

// method is provided to manually signal that a C++ object		// method is provided to manually signal that a C++ object
// is no longer needed and can be deleted		// is no longer needed and can be deleted
delete(): void;		delete(): void;
}		}

export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;		export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;

[identity] Remove outdated comment from constantsClosedPublicActions