[native] Move margin getter in Tooltip to functional component
ClosedPublic
Actions

Authored by angelika on Dec 11 2024, 3:34 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM0691b0b4964c: [native] Move margin getter in Tooltip to functional component

Summary

Simply move get margin function to functional component as a part of Tooltip migration to functional component.

Depends on: D14103

Test Plan

Open some tooltips and verify they're positioned correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Dec 11 2024, 3:34 PM

angelika held this revision as a draft.

angelika edited the summary of this revision. (Show Details)Dec 11 2024, 3:35 PM

angelika added a parent revision: D14103: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API.

angelika added a child revision: D14106: [native] Move tooltip height getter in Tooltip to functional component.Dec 11 2024, 3:37 PM

Harbormaster completed remote builds in B33004: Diff 46322.Dec 11 2024, 4:08 PM

angelika published this revision for review.Dec 12 2024, 12:53 AM

ashoat accepted this revision.Dec 12 2024, 1:43 AM

ashoat added inline comments.

native/tooltip/tooltip.react.js
559–564 ↗	(On Diff #46322)	I would make this a memo and replace the getter with the value itself. (Feel free to address this later in the stack)

This revision is now accepted and ready to land.Dec 12 2024, 1:43 AM

Rebase and address feedback

Harbormaster completed remote builds in B33080: Diff 46402.Dec 13 2024, 2:07 PM

angelika marked an inline comment as done.Dec 13 2024, 2:08 PM

Rebase

Harbormaster completed remote builds in B33124: Diff 46465.Dec 16 2024, 3:02 PM

Closed by commit rCOMM0691b0b4964c: [native] Move margin getter in Tooltip to functional component. · Explain WhyDec 16 2024, 9:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM0691b0b4964c: [native] Move margin getter in Tooltip to functional component.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

tooltip.react.js

31 lines

Diff 46501

View Options

native/tooltip/tooltip.react.js

[native] Move margin getter in Tooltip to functional componentClosedPublicActions