Simply move reanimated nodes to functional component as a part of Tooltip migration to functional component.
Depends on D14107
Details
Details
Open up some tooltips and verify they're animated correctly
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/tooltip/tooltip.react.js | ||
|---|---|---|
| 575 ↗ | (On Diff #46326) | useValue would be cleaner here I guess this will get deleted later in the stack anyways... if so feel free to ignore the feedback |
| 592–595 ↗ | (On Diff #46326) | One slight change here: now when the screen dimensions change, we will replace the Reanimated value. Generally this is an anti-pattern, but it probably doesn't matter here because (1) we only allow screen rotation in rare places in the app, and I don't think we have Tooltips there, (2) this probably gets replaced with worklets later anyways... not sure if the feedback will still be relevant after that |