[native] Move haptics in Tooltip to functional compononent
ClosedPublic
Actions

Authored by angelika on Dec 11 2024, 3:47 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM66f08779a84d: [native] Move haptics in Tooltip to functional compononent

Summary

Move Haptics.impactAsync() call to functional component as a part of Tooltip migration to functional component.

Depends on D14109

Test Plan

Open up a tooltip and verify the phone vibrates.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Dec 11 2024, 3:47 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 11 2024, 3:47 PM

angelika edited the test plan for this revision. (Show Details)Dec 11 2024, 3:48 PM

angelika added reviewers: ashoat, tomek.

angelika added a child revision: D14111: [native] Move methods from Tooltip to functional compononent.Dec 11 2024, 3:54 PM

Harbormaster completed remote builds in B33010: Diff 46328.Dec 11 2024, 5:10 PM

angelika published this revision for review.Dec 12 2024, 12:55 AM

ashoat accepted this revision.Dec 12 2024, 1:53 AM

This revision is now accepted and ready to land.Dec 12 2024, 1:53 AM

Rebase and address feedback

Harbormaster completed remote builds in B33085: Diff 46407.Dec 13 2024, 2:50 PM

Rebase

Harbormaster completed remote builds in B33129: Diff 46470.Dec 16 2024, 3:44 PM

Closed by commit rCOMM66f08779a84d: [native] Move haptics in Tooltip to functional compononent. · Explain WhyDec 16 2024, 9:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM66f08779a84d: [native] Move haptics in Tooltip to functional compononent.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

tooltip.react.js

8 lines

Diff 46506

View Options

native/tooltip/tooltip.react.js

[native] Move haptics in Tooltip to functional compononentClosedPublicActions