[native] Move methods from Tooltip to functional compononent
ClosedPublic
Actions

Authored by angelika on Dec 11 2024, 3:54 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM613958367d7f: [native] Move methods from Tooltip to functional compononent

Summary

Move getTooltipItem, onPressMore, renderMoreIcon and onTooltipContainerLayout to the functional compoent as a part of Tooltip migration to functional component.

Depends on D14110

Test Plan

Open up some tooltips and verify they're looking correctly.
Open text message tooltip and press More, verify it works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Dec 11 2024, 3:54 PM

angelika held this revision as a draft.

angelika edited the summary of this revision. (Show Details)Dec 11 2024, 3:54 PM

angelika edited the test plan for this revision. (Show Details)

angelika added a child revision: D14112: [native] Move render function from Tooltip to functional component.Dec 11 2024, 3:59 PM

Harbormaster completed remote builds in B33011: Diff 46329.Dec 11 2024, 5:18 PM

angelika published this revision for review.Dec 12 2024, 12:55 AM

ashoat accepted this revision.Dec 12 2024, 1:55 AM

ashoat added inline comments.

native/tooltip/tooltip.react.js
562–566 ↗	(On Diff #46329)	We don't need to convert this into a callback... and in this case, I don't think we need a `React.useMemo` either. Arguably we can just pass in `tooltipItem={boundTooltipItem}`
573–578 ↗	(On Diff #46329)	Can be a memo