Page MenuHomePhabricator
Differential D14127

[native] Remove progress prop from tooltip buttons components
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 10:50 AM.
Tags
None
Referenced Files
F3507317: D14127.diff
Fri, Dec 20, 8:11 PM
F3506865: D14127.id46484.diff
Fri, Dec 20, 6:26 PM
F3504967: D14127.id46346.diff
Fri, Dec 20, 11:38 AM
F3500690: D14127.id46421.diff
Fri, Dec 20, 2:15 AM
F3500510: D14127.id.diff
Fri, Dec 20, 1:51 AM
F3498455: D14127.id46346.diff
Thu, Dec 19, 9:12 PM
Unknown Object (File)
Wed, Dec 18, 7:23 PM
Unknown Object (File)
Tue, Dec 17, 8:03 PM
View All 9 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe47bfc45f374: [native] Remove progress prop from tooltip buttons components
Summary

Remove old unecessary progress value from tooltip buttons components. Separate diff because it changes multiple files at once.

Depends on D14126

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 10:50 AM
angelika held this revision as a draft.
angelika edited the summary of this revision. (Show Details)Wed, Dec 11, 10:51 AM
angelika added a parent revision: D14126: [native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API.
angelika added a child revision: D14128: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API.Wed, Dec 11, 11:00 AM
Harbormaster completed remote builds in B33028: Diff 46346.Wed, Dec 11, 12:12 PM
angelika published this revision for review.Wed, Dec 11, 5:28 PM
ashoat accepted this revision.Wed, Dec 11, 7:56 PM
This revision is now accepted and ready to land.Wed, Dec 11, 7:56 PM
angelika updated this revision to Diff 46421.Fri, Dec 13, 5:39 AM

Rebase and address feedback

Harbormaster completed remote builds in B33099: Diff 46421.Fri, Dec 13, 8:47 AM
angelika updated this revision to Diff 46484.Mon, Dec 16, 6:24 AM

Rebase

Harbormaster completed remote builds in B33143: Diff 46484.Mon, Dec 16, 9:45 AM
Closed by commit rCOMMe47bfc45f374: [native] Remove progress prop from tooltip buttons components (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMe47bfc45f374: [native] Remove progress prop from tooltip buttons components.

Revision Contents
Changeset List

Diff 46520

View Options

native/chat/multimedia-message-tooltip-button.react.js

Loading...
View Options

native/chat/robotext-message-tooltip-button.react.js

Loading...
View Options

native/chat/text-message-tooltip-button.react.js

Loading...
View Options

native/tooltip/tooltip.react.js

Loading...