[native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 11:00 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM44c6957aa85a: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity…

Summary

Ideally I'd split it into 3 diffs but I guess it would be more trouble than it's worth because both useContentAndHeaderOpacity and useDeliveryIconOpacity use useOverlayPosition so I'd need to create a temporary copy of useOverlayPosition that returns v2, migrate useContentAndHeaderOpacity, migrate useDeliveryIconOpacity and delete a copy of useOverlayPosition that returns v1. And the migration here is straightforward: instead of returning a number or reanimated node we return a SharedValue from useDerivedValue with the exact same logic and I replaced useMemo with useAnimatedStyle when needed.

Depends on D14127

Test Plan

Open up a tooltip on text and robotext message and navigate to thread. Verify the transition looks correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 11:00 AM

angelika held this revision as a draft.

angelika edited the summary of this revision. (Show Details)Wed, Dec 11, 11:00 AM

angelika added a parent revision: D14127: [native] Remove progress prop from tooltip buttons components.

angelika added a child revision: D14129: [native] Workarounds for bugs after reanimated migration.Wed, Dec 11, 11:55 AM

Harbormaster completed remote builds in B33029: Diff 46347.Wed, Dec 11, 12:22 PM

angelika published this revision for review.Wed, Dec 11, 5:29 PM

ashoat accepted this revision.Wed, Dec 11, 7:58 PM

ashoat added inline comments.

native/chat/composed-message.react.js
117–121 ↗	(On Diff #46347)	Nit
native/chat/utils.js
292 ↗	(On Diff #46347)	The docs seem to indicate that the dep lists only help `useAnimatedStyle` when used without the Babel plugin on web, but not sure if that's fully true

This revision is now accepted and ready to land.Wed, Dec 11, 7:58 PM

Rebase and address feedback

angelika marked 2 inline comments as done.Fri, Dec 13, 6:24 AM

angelika added inline comments.

native/chat/utils.js
292 ↗	(On Diff #46347)	Yes, in v3 docs it's mentioned. However it's not mentioned in v2 docs: https://docs.swmansion.com/react-native-reanimated/docs/2.x/api/hooks/useAnimatedStyle#dependencies-array and we're still using v2. So to be on a safe side I kept the dependencies.