Page MenuHomePhabricator
Differential D14131

[native] Move view ref in MultimediaMessageMultimedia to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 12:07 PM.
Tags
None
Referenced Files
F3513014: D14131.id46426.diff
Sat, Dec 21, 9:39 PM
Unknown Object (File)
Sat, Dec 21, 5:03 PM
Unknown Object (File)
Sat, Dec 21, 2:46 PM
Unknown Object (File)
Sat, Dec 21, 8:58 AM
Unknown Object (File)
Sat, Dec 21, 6:08 AM
Unknown Object (File)
Sat, Dec 21, 1:53 AM
Unknown Object (File)
Fri, Dec 20, 7:59 PM
Unknown Object (File)
Fri, Dec 20, 7:44 PM
View All 14 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMfcbbc62e5707: [native] Move view ref in MultimediaMessageMultimedia to functional component
Summary

Move view ref to functional component as a part of MultimediaMessageMultimedia migration to a functional component.

Depends on D14130

Test Plan

Open up a multimedia message and see if it behaves correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 12:07 PM
angelika held this revision as a draft.
angelika edited the summary of this revision. (Show Details)Wed, Dec 11, 12:08 PM
angelika added a parent revision: D14130: [native] Migrate ActionResultModal component to Reanimated v2 API.
angelika added a child revision: D14132: [native] Move onPress and onLayout methods in MultimediaMessageMultimedia to functional component.Wed, Dec 11, 12:14 PM
Harbormaster completed remote builds in B33032: Diff 46350.Wed, Dec 11, 12:48 PM
angelika published this revision for review.Wed, Dec 11, 5:29 PM
ashoat accepted this revision.Wed, Dec 11, 8:02 PM
This revision is now accepted and ready to land.Wed, Dec 11, 8:02 PM
angelika updated this revision to Diff 46425.Fri, Dec 13, 5:41 AM

Rebase and address feedback

Harbormaster completed remote builds in B33103: Diff 46425.Fri, Dec 13, 9:21 AM
angelika updated this revision to Diff 46488.Mon, Dec 16, 6:24 AM

Rebase

Harbormaster completed remote builds in B33147: Diff 46488.Mon, Dec 16, 10:18 AM
Closed by commit rCOMMfcbbc62e5707: [native] Move view ref in MultimediaMessageMultimedia to functional component (authored by angelika). · Explain WhyMon, Dec 16, 1:35 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMfcbbc62e5707: [native] Move view ref in MultimediaMessageMultimedia to functional component.

Revision Contents
Changeset List

PathSize
native/
chat/
18 lines

Diff 46524

View Options

native/chat/multimedia-message-multimedia.react.js

Loading...