Details

Reviewers

ashoat
tomek

Commits

rCOMMf8b744c38505: [native] Move render function in MultimediaMessageMultimedia to functional…

Summary

Move render() function to functional component as a part of MultimediaMessageMultimedia migration to a functional component. This finishes the migration of the MultimediaMessageMultimedia component to a functional component.

Depends on D14134

Test Plan

Open up a multimedia message and see if it behaves correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Dec 11 2024, 8:38 PM

angelika held this revision as a draft.

angelika edited the summary of this revision. (Show Details)Dec 11 2024, 8:38 PM

angelika added a parent revision: D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.

Harbormaster completed remote builds in B33036: Diff 46354.Dec 11 2024, 9:22 PM

angelika published this revision for review.Dec 12 2024, 1:30 AM

ashoat accepted this revision.Dec 12 2024, 4:11 AM

ashoat added inline comments.

native/chat/multimedia-message-multimedia.react.js
28 ↗	(On Diff #46354)	This can be renamed
53 ↗	(On Diff #46354)	This can be renamed
156 ↗	(On Diff #46354)	Can you wrap this with a `React.useMemo`?

This revision is now accepted and ready to land.Dec 12 2024, 4:11 AM

Rebase and address feedback

angelika marked 3 inline comments as done.Dec 13 2024, 2:29 PM

Harbormaster completed remote builds in B33107: Diff 46429.Dec 13 2024, 5:54 PM

Rebase

Harbormaster completed remote builds in B33151: Diff 46492.Dec 16 2024, 6:52 PM

Harbormaster completed remote builds in B33152: Diff 46493.Dec 16 2024, 7:00 PM

Closed by commit rCOMMf8b744c38505: [native] Move render function in MultimediaMessageMultimedia to functional…. · Explain WhyDec 16 2024, 9:35 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMf8b744c38505: [native] Move render function in MultimediaMessageMultimedia to functional….

[native] Move render function in MultimediaMessageMultimedia to functional component
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 46429

native/chat/multimedia-message-multimedia.react.js

[native] Move render function in MultimediaMessageMultimedia to functional componentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46429

native/chat/multimedia-message-multimedia.react.js

[native] Move render function in MultimediaMessageMultimedia to functional component
ClosedPublic
Actions

Revision Contents
Changeset List