Page MenuHomePhabricator

[lib] Fix stack overflow from lastUpdatedTime
ClosedPublic

Authored by ashoat on Fri, Dec 13, 9:09 AM.
Tags
None
Referenced Files
F3512913: D14156.diff
Sat, Dec 21, 8:59 PM
F3511973: D14156.diff
Sat, Dec 21, 5:39 PM
Unknown Object (File)
Fri, Dec 20, 3:13 PM
Unknown Object (File)
Fri, Dec 20, 12:26 PM
Unknown Object (File)
Fri, Dec 20, 9:35 AM
Unknown Object (File)
Wed, Dec 18, 6:28 PM
Unknown Object (File)
Fri, Dec 13, 9:54 PM
Unknown Object (File)
Fri, Dec 13, 9:53 PM
Subscribers
None

Details

Summary

This resolves ENG-10016. It looks like when this was changed from an immediately-invoked Promise to a function that returns a Promise, we ended up in a situation where the lastUpdatedTime dereference ended up resolving to the new value rather than the prior value.

Test Plan

Prior to this change, I was able to reproduce the issue in the Linear task. Afterwards, it no longer reproduces

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable