Details
Details
Test button
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
native/account/qr-auth/qr-code-scanner-left-button.react.js | ||
---|---|---|
25–31 ↗ | (On Diff #46458) | Inspired by close button in CameraModal but instead of Text x I used icon. |
native/account/qr-auth/qr-code-scanner-left-button.react.js | ||
---|---|---|
10–12 ↗ | (On Diff #46458) | It's a little weird that we're passing all of these props in but only using one. Should we just have a single prop instead? In that case we could potentially reuse this component, such as in CameraModal |
25–31 ↗ | (On Diff #46458) | In CameraModal we actually use the text ×, not the text x. I'm okay with the icon instead, but I think either option is fine |
native/navigation/header-close-left-button.react.js | ||
---|---|---|
10–32 ↗ | (On Diff #46542) |
native/navigation/header-close-left-button.react.js | ||
---|---|---|
11 ↗ | (On Diff #46542) | This has to be optional because this is how it is defined in StackHeaderLeftButtonProps |