[native] extract migrating to new flow to a hook
ClosedPublic
Actions

Authored by kamil on Jan 16 2025, 12:07 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM3ef8bdf93470: [native] extract migrating to new flow to a hook

Summary

ENG-10094.

Here, I just move the code around to make it more readable. Changes in this diff are helpful later in the stack.

The conditions are updated in the next diff.

Depends on D14211

Test Plan

Tested later in the stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 16 2025, 12:07 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 16 2025, 12:08 PM

Harbormaster completed remote builds in B33251: Diff 46695.Jan 16 2025, 12:25 PM

kamil added a child revision: D14213: [native] cleanup code related to getting device list and add code comments.Jan 16 2025, 12:59 PM

kamil published this revision for review.Jan 16 2025, 2:44 PM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.

native/backup/use-migration-to-new-flow.js
1 ↗	(On Diff #46695)	logic here is a copy-paste

tomek accepted this revision.Jan 16 2025, 3:11 PM

This revision is now accepted and ready to land.Jan 16 2025, 3:11 PM

bartek accepted this revision.Jan 17 2025, 11:41 AM

Closed by commit rCOMM3ef8bdf93470: [native] extract migrating to new flow to a hook. · Explain WhyJan 20 2025, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3ef8bdf93470: [native] extract migrating to new flow to a hook.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

127 lines

use-migration-to-new-flow.js

150 lines

Diff 46713

View Options

native/backup/backup-handler.js