Paths

Table of Contentst

Differential D14213

[native] cleanup code related to getting device list and add code comments
ClosedPublic
Actions

Authored by kamil on Jan 16 2025, 12:59 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM325cb59e412e: [native] cleanup code related to getting device list and add code comments

Summary

Code improvements with comments because logic is really complex.

Depends on D14212

Test Plan

Tested later in the stack

Diff Detail

Repository

Branch

publish-flow-fixes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jan 16 2025, 12:59 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 16 2025, 12:59 PM

kamil added a child revision: D14214: [native] improve conditions about performing migration.Jan 16 2025, 1:08 PM

Harbormaster failed remote builds in B33252: Diff 46696!Jan 16 2025, 1:13 PM

fix Flow

kamil published this revision for review.Jan 16 2025, 2:46 PM

kamil added inline comments.

native/backup/backup-handler.js
110–115	this is moved below to improve identation

Harbormaster completed remote builds in B33254: Diff 46698.Jan 16 2025, 2:47 PM

tomek accepted this revision.Jan 17 2025, 11:28 AM

tomek added inline comments.

native/backup/use-migration-to-new-flow.js
56	Why are we making this optional?

This revision is now accepted and ready to land.Jan 17 2025, 11:28 AM

bartek accepted this revision.Jan 17 2025, 11:44 AM

bartek added inline comments.

native/backup/use-migration-to-new-flow.js
80–82	Not sure if Flow won't complain but it could be better to make this check before calling this hook, and leave `currentIdentityUserState` non-optional here

address review

Harbormaster completed remote builds in B33262: Diff 46706.Jan 20 2025, 11:45 AM

Closed by commit rCOMM325cb59e412e: [native] cleanup code related to getting device list and add code comments. · Explain WhyJan 20 2025, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM325cb59e412e: [native] cleanup code related to getting device list and add code comments.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

40 lines

use-migration-to-new-flow.js

8 lines

Diff 46698

native/backup/backup-handler.js

Loading...

native/backup/use-migration-to-new-flow.js

Loading...