Details

Reviewers

bartek
tomek

Commits

rCOMM8c3bf7ea0775: [native] handle errors when running migration to new flow

Summary

ENG-10094.

getAuthMetadata can throw and then backupUploadInProgress is set to true forever

Depends on D14215

Test Plan

simulate error and check if it thrown

Diff Detail

Repository

rCOMM Comm

Branch

publish-flow-fixes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jan 16 2025, 2:40 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 16 2025, 2:40 PM

kamil added a child revision: D14217: [native] fix creating new device list in `reorderAndSignDeviceList`.Jan 16 2025, 2:41 PM

kamil published this revision for review.Jan 16 2025, 2:49 PM

Harbormaster completed remote builds in B33257: Diff 46701.Jan 16 2025, 3:02 PM

tomek accepted this revision.Jan 17 2025, 11:40 AM

This revision is now accepted and ready to land.Jan 17 2025, 11:40 AM

bartek accepted this revision.Jan 17 2025, 12:15 PM

bartek added inline comments.

native/backup/backup-handler.js
126–127	Don't we want to console log this error or something?

kamil added inline comments.Jan 20 2025, 11:42 AM

native/backup/backup-handler.js
126–127	I don't think so, `getAuthMetadata` was implemented in the way that it is throwing when data is missing, not only when something went wrong

kamil edited parent revisions, added: D14214: [native] improve conditions about performing migration; removed: D14215: [native] fix not starting backup handler when performing migration to new flow.Jan 20 2025, 11:43 AM

Closed by commit rCOMM8c3bf7ea0775: [native] handle errors when running migration to new flow. · Explain WhyJan 20 2025, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM8c3bf7ea0775: [native] handle errors when running migration to new flow.

[native] handle errors when running migration to new flow
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 46701

native/backup/backup-handler.js

[native] handle errors when running migration to new flowClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46701

native/backup/backup-handler.js

[native] handle errors when running migration to new flow
ClosedPublic
Actions

Revision Contents
Changeset List