[native] Migrate flashMode in CameraModal to functional component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 12:11 PM.

Details

Reviewers

tomek

Commits

rCOMM90016ce1e64b: [native] Migrate flashMode in CameraModal to functional component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax
Migrate flashMode state to functional component.

Depends on D14221

Test Plan

Change flash mode in camera modal.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jan 20 2025, 12:11 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 12:11 PM

angelika added a child revision: D14223: [native] Migrate useFrontCamera in CameraModal to functional component.Jan 20 2025, 12:13 PM

Harbormaster completed remote builds in B33266: Diff 46719.Jan 20 2025, 12:28 PM

angelika requested review of this revision.Jan 20 2025, 12:28 PM

tomek accepted this revision.Jan 20 2025, 12:55 PM

tomek added inline comments.

native/media/camera-modal.react.js
1184–1190	Wouldn't it be safer to have this logic as a callback argument to `setFlashMode`? (`setFlashMode(prevMode => ...)`)

This revision is now accepted and ready to land.Jan 20 2025, 12:55 PM

Rebase

angelika marked an inline comment as done.Jan 22 2025, 12:45 AM

Harbormaster completed remote builds in B33295: Diff 46752.Jan 22 2025, 12:53 AM

Closed by commit rCOMM90016ce1e64b: [native] Migrate flashMode in CameraModal to functional component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM90016ce1e64b: [native] Migrate flashMode in CameraModal to functional component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

38 lines

Diff 46719

View Options

native/media/camera-modal.react.js

[native] Migrate flashMode in CameraModal to functional componentClosedPublicActions