Differential D14224

[native] Migrate hasCamerasOnBothSides and fetching cameras in CameraModal to funcitonal component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 12:14 PM.

Details

Reviewers

tomek

Commits

rCOMMec761a1bc6d2: [native] Migrate hasCamerasOnBothSides and fetching cameras in CameraModal to…

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

Migrate hasCamerasOnBothSides state to functional component

Depends on D14223

Test Plan

Test switching between front and back camera

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jan 20 2025, 12:14 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 12:14 PM

angelika added a child revision: D14225: [native] Migrate autoFocusPointOfInterest in CameraModal to funcitonal component.Jan 20 2025, 12:16 PM

Harbormaster completed remote builds in B33268: Diff 46721.Jan 20 2025, 12:44 PM

angelika published this revision for review.Jan 20 2025, 1:24 PM

tomek accepted this revision.Jan 20 2025, 2:40 PM

This revision is now accepted and ready to land.Jan 20 2025, 2:40 PM

Rebase

Harbormaster completed remote builds in B33297: Diff 46754.Jan 22 2025, 1:09 AM

Closed by commit rCOMMec761a1bc6d2: [native] Migrate hasCamerasOnBothSides and fetching cameras in CameraModal to…. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMec761a1bc6d2: [native] Migrate hasCamerasOnBothSides and fetching cameras in CameraModal to….

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

108 lines

Diff 46754

View Options

native/media/camera-modal.react.js

[native] Migrate hasCamerasOnBothSides and fetching cameras in CameraModal to funcitonal componentClosedPublicActions