Differential D14229

[native] Migrate camera ref in CameraModal to funcitonal component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 12:23 PM.

Details

Reviewers

tomek

Commits

rCOMMfbab5a7e358a: [native] Migrate camera ref in CameraModal to funcitonal component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

Migrate camera ref to functional component

Depends on D14228

Test Plan

Verify taking photos works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jan 20 2025, 12:23 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 12:23 PM

angelika added a child revision: D14230: [native] Migrate take and send photos logic in CameraModal to funcitonal component.Jan 20 2025, 12:25 PM

angelika published this revision for review.Jan 20 2025, 1:25 PM

Harbormaster completed remote builds in B33273: Diff 46726.Jan 20 2025, 1:27 PM

tomek accepted this revision.Jan 20 2025, 3:00 PM

This revision is now accepted and ready to land.Jan 20 2025, 3:00 PM

Rebase

Harbormaster completed remote builds in B33302: Diff 46759.Jan 22 2025, 1:52 AM

Closed by commit rCOMMfbab5a7e358a: [native] Migrate camera ref in CameraModal to funcitonal component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMfbab5a7e358a: [native] Migrate camera ref in CameraModal to funcitonal component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

26 lines

Diff 46792

View Options

native/media/camera-modal.react.js

[native] Migrate camera ref in CameraModal to funcitonal componentClosedPublicActions