[native] Migrate send button style in CameraModal to functional component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 1:09 PM.

Details

Reviewers

tomek

Commits

rCOMM2cce1a1f7aec: [native] Migrate send button style in CameraModal to functional component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

This animation is in RN's Animated API. I considered changing it to reaniamted api, but SendMediaButton is used in several places
and I'd have to change them all. So I just moved the animation code to functional component.

Depends on D14236

Test Plan

Verify send button is animated correctly

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jan 20 2025, 1:09 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 1:09 PM

angelika added a child revision: D14238: [native] Migrate componentDidUpdate in CameraModal to functional component.Jan 20 2025, 1:12 PM

angelika published this revision for review.Jan 20 2025, 1:27 PM

Harbormaster completed remote builds in B33281: Diff 46734.Jan 20 2025, 2:36 PM

tomek accepted this revision.Jan 21 2025, 10:04 AM

This revision is now accepted and ready to land.Jan 21 2025, 10:04 AM

Rebase

Harbormaster completed remote builds in B33310: Diff 46767.Jan 22 2025, 3:01 AM

Closed by commit rCOMM2cce1a1f7aec: [native] Migrate send button style in CameraModal to functional component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM2cce1a1f7aec: [native] Migrate send button style in CameraModal to functional component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

40 lines

Diff 46734

View Options

native/media/camera-modal.react.js

[native] Migrate send button style in CameraModal to functional componentClosedPublicActions