Differential D14240

[native] Migrate render functions in CameraModal to functional component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 1:16 PM.

Details

Reviewers

tomek

Commits

rCOMMb2c8e7f6ca53: [native] Migrate render functions in CameraModal to functional component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

Last step towards migrating CameraModal to a functional component: move render functions to functional component, get rid of props and rename the functional component to CameraModal

Depends on D14239

Test Plan

Verify camera modal looks correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jan 20 2025, 1:16 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 1:16 PM

angelika added a child revision: D14241: [native] Fix focus animation on devices with top notches in CameraModal.Jan 20 2025, 1:20 PM

angelika published this revision for review.Jan 20 2025, 1:27 PM

Harbormaster completed remote builds in B33284: Diff 46737.Jan 20 2025, 3:02 PM

tomek accepted this revision.Jan 21 2025, 10:15 AM

This revision is now accepted and ready to land.Jan 21 2025, 10:15 AM

Rebase

Harbormaster completed remote builds in B33313: Diff 46770.Jan 22 2025, 3:27 AM

Closed by commit rCOMMb2c8e7f6ca53: [native] Migrate render functions in CameraModal to functional component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMb2c8e7f6ca53: [native] Migrate render functions in CameraModal to functional component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

436 lines

Diff 46770

View Options

native/media/camera-modal.react.js

[native] Migrate render functions in CameraModal to functional componentClosedPublicActions