[native][lib] combine `siweMessage` and `siweSignature` into `SignedMessage` type
ClosedPublic
Actions

Authored by kamil on Jan 28 2025, 1:15 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMMba0900cc26ae: [native][lib] combine `siweMessage` and `siweSignature` into `SignedMessage`…

Summary

Part of ENG-10112 and ENG-10113

JS part of improvement from D14255

Depends on D14255

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 28 2025, 1:15 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 28 2025, 1:15 PM

Harbormaster completed remote builds in B33328: Diff 46819.Jan 28 2025, 1:33 PM

kamil published this revision for review.Jan 28 2025, 1:35 PM

kamil added a child revision: D14257: [CommCoreModule] move `restoreUser` from `CommRustModule` to `CommCoreModule`.Jan 28 2025, 1:36 PM

tomek accepted this revision.Jan 29 2025, 6:37 PM

This revision is now accepted and ready to land.Jan 29 2025, 6:37 PM

Closed by commit rCOMMba0900cc26ae: [native][lib] combine `siweMessage` and `siweSignature` into `SignedMessage`…. · Explain WhyJan 30 2025, 2:19 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMba0900cc26ae: [native][lib] combine `siweMessage` and `siweSignature` into `SignedMessage`….

Revision Contents
Changeset List

Path

Size

lib/

types/

identity-service-types.js

4 lines

native/

account/

restore-backup-screen.react.js

3 lines

restore.js

31 lines

identity-service/

identity-service-context-provider.react.js

8 lines

Diff 46877

View Options

lib/types/identity-service-types.js

View Options

native/account/restore-backup-screen.react.js

View Options

native/account/restore.js

View Options

native/identity-service/identity-service-context-provider.react.js

[native][lib] combine `siweMessage` and `siweSignature` into `SignedMessage` typeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46877

lib/types/identity-service-types.js

native/account/restore-backup-screen.react.js

native/account/restore.js

native/identity-service/identity-service-context-provider.react.js

[native][lib] combine `siweMessage` and `siweSignature` into `SignedMessage` type
ClosedPublic
Actions

Revision Contents
Changeset List