[native_rust_library][CommCoreModule] add User Keys params to restore user RPC
ClosedPublic
Actions

Authored by kamil on Jan 29 2025, 7:35 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM04e80dac16f5: [native_rust_library][CommCoreModule] add User Keys params to restore user RPC

Summary

Part of ENG-10112 and ENG-10113

We need to add the params needed to User Keys creation.

Not sure if we can somehow reduce the number of parameters here, but it started to reduce readability.

Depends on D14271

Test Plan

Build app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 29 2025, 7:35 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 29 2025, 7:35 AM

kamil added a child revision: D14273: [native_rust_library] create User Keys backup when restoring user.Jan 29 2025, 7:39 AM

kamil published this revision for review.Jan 29 2025, 7:41 AM

kamil edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B33347: Diff 46842.Jan 29 2025, 8:54 AM

Not sure if we can somehow reduce the number of parameters here, but it started to reduce readability.

That's definitely a good idea, especially because we have a lot of parameters with the same type, so the chance of a mistake is quite high. According to https://cxx.rs/shared.html we should be able to use structs for this purpose.

This revision is now accepted and ready to land.Jan 29 2025, 10:59 AM

In D14272#397082, @tomek wrote:

Not sure if we can somehow reduce the number of parameters here, but it started to reduce readability.

That's definitely a good idea, especially because we have a lot of parameters with the same type, so the chance of a mistake is quite high. According to https://cxx.rs/shared.html we should be able to use structs for this purpose.

ENG-10146

Closed by commit rCOMM04e80dac16f5: [native_rust_library][CommCoreModule] add User Keys params to restore user RPC (authored by kamil). · Explain WhyWed, Feb 5, 6:10 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM04e80dac16f5: [native_rust_library][CommCoreModule] add User Keys params to restore user RPC.