Page MenuHomePhabricator
Differential D14273

[native_rust_library] create User Keys backup when restoring user
ClosedPublic
Actions

Authored by kamil on Jan 29 2025, 7:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 10:09 AM
Unknown Object (File)
Fri, Feb 28, 10:09 AM
Unknown Object (File)
Wed, Feb 26, 1:49 PM
Unknown Object (File)
Wed, Feb 26, 11:22 AM
Unknown Object (File)
Tue, Feb 25, 10:44 PM
Unknown Object (File)
Mon, Feb 24, 4:47 PM
Unknown Object (File)
Mon, Feb 24, 6:01 AM
Unknown Object (File)
Sun, Feb 23, 11:56 AM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM7d4aa49fbc32: [native_rust_library] create User Keys backup when restoring user
Summary

ENG-10113

Creating User Keys backup. Publishing this diff but it needs to be updated after the service part is finished.

NOTE: This stack should not be landed before the Identity is deployed on staging.

Depends on D14272, D14270

Test Plan

Test plan described here

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jan 29 2025, 7:39 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJan 29 2025, 7:39 AM
kamil published this revision for review.Jan 29 2025, 7:42 AM
kamil edited the summary of this revision. (Show Details)
kamil added inline comments.
native/native_rust_library/src/identity/login.rs
290–301 ↗(On Diff #46843)

This needs to be updated after the service part is done (cc. @bartek)

ashoat added inline comments.Jan 29 2025, 8:41 AM
native/native_rust_library/src/identity/login.rs
290–301 ↗(On Diff #46843)

Is there a task to track this?

Harbormaster completed remote builds in B33348: Diff 46843.Jan 29 2025, 9:05 AM
kamil added inline comments.Jan 30 2025, 1:49 AM
native/native_rust_library/src/identity/login.rs
290–301 ↗(On Diff #46843)

sure, it's ENG-10114 and ENG-10115, @bartek is working on it right now

bartek mentioned this in D14280: [proto] Add UserKeys backup fields to RestoreUserRequest.Jan 30 2025, 2:15 AM
bartek added inline comments.
native/native_rust_library/src/identity/login.rs
290–301 ↗(On Diff #46843)

My part is here - https://phab.comm.dev/D14280#inline-79687 - this diff should probably be rebased on that one

bartek mentioned this in D14283: [identity] Upload UserKeys backup in RestoreUser RPC.Jan 30 2025, 3:51 AM
kamil added a child revision: D14285: [native] update Restore Protocol comment.Jan 30 2025, 6:29 AM
kamil mentioned this in rCOMM6977f5da1e62: [proto] Add UserKeys backup fields to RestoreUserRequest.Wed, Feb 5, 3:47 AM
kamil mentioned this in rCOMM9a7a4d05e65b: [identity] Upload UserKeys backup in RestoreUser RPC.
kamil removed a child revision: D14285: [native] update Restore Protocol comment.Wed, Feb 5, 6:23 AM
kamil updated this revision to Diff 46920.Wed, Feb 5, 6:46 AM

rebase

Harbormaster failed remote builds in B33394: Diff 46920!Wed, Feb 5, 6:58 AM
tomek accepted this revision.Wed, Feb 5, 8:44 AM
This revision is now accepted and ready to land.Wed, Feb 5, 8:44 AM
kamil updated this revision to Diff 46931.Thu, Feb 6, 1:39 AM

CI

Harbormaster completed remote builds in B33404: Diff 46931.Thu, Feb 6, 1:57 AM
Closed by commit rCOMM7d4aa49fbc32: [native_rust_library] create User Keys backup when restoring user (authored by kamil). · Explain WhyThu, Feb 6, 2:08 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM7d4aa49fbc32: [native_rust_library] create User Keys backup when restoring user.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
42 lines
identity/
37 lines
8 lines

Diff 46936

View Options

native/native_rust_library/src/backup.rs

Loading...
View Options

native/native_rust_library/src/identity/login.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...