[native_rust_library] create User Keys backup when restoring user
ClosedPublic
Actions

Authored by kamil on Jan 29 2025, 3:39 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM7d4aa49fbc32: [native_rust_library] create User Keys backup when restoring user

Summary

ENG-10113

Creating User Keys backup. Publishing this diff but it needs to be updated after the service part is finished.

NOTE: This stack should not be landed before the Identity is deployed on staging.

Depends on D14272, D14270

Test Plan

Test plan described here

Diff Detail

Repository

rCOMM Comm

Branch

set-backup-secrets-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jan 29 2025, 3:39 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 29 2025, 3:39 PM

kamil published this revision for review.Jan 29 2025, 3:42 PM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.

native/native_rust_library/src/identity/login.rs
290–301	This needs to be updated after the service part is done (cc. @bartek)

ashoat added inline comments.Jan 29 2025, 4:41 PM

native/native_rust_library/src/identity/login.rs
290–301	Is there a task to track this?

Harbormaster completed remote builds in B33348: Diff 46843.Jan 29 2025, 5:05 PM

kamil added inline comments.Jan 30 2025, 9:49 AM

native/native_rust_library/src/identity/login.rs
290–301	sure, it's ENG-10114 and ENG-10115, @bartek is working on it right now

bartek mentioned this in D14280: [proto] Add UserKeys backup fields to RestoreUserRequest.Jan 30 2025, 10:15 AM

bartek added inline comments.

native/native_rust_library/src/identity/login.rs
290–301	My part is here - https://phab.comm.dev/D14280#inline-79687 - this diff should probably be rebased on that one

bartek mentioned this in D14283: [identity] Upload UserKeys backup in RestoreUser RPC.Jan 30 2025, 11:51 AM

kamil added a child revision: D14285: [native] update Restore Protocol comment.Jan 30 2025, 2:29 PM

kamil mentioned this in rCOMM6977f5da1e62: [proto] Add UserKeys backup fields to RestoreUserRequest.Feb 5 2025, 11:47 AM

kamil mentioned this in rCOMM9a7a4d05e65b: [identity] Upload UserKeys backup in RestoreUser RPC.

kamil removed a child revision: D14285: [native] update Restore Protocol comment.Feb 5 2025, 2:23 PM

rebase

Harbormaster failed remote builds in B33394: Diff 46920!Feb 5 2025, 2:58 PM

tomek accepted this revision.Feb 5 2025, 4:44 PM

This revision is now accepted and ready to land.Feb 5 2025, 4:44 PM

Harbormaster completed remote builds in B33404: Diff 46931.Feb 6 2025, 9:57 AM

Closed by commit rCOMM7d4aa49fbc32: [native_rust_library] create User Keys backup when restoring user. · Explain WhyFeb 6 2025, 10:08 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM7d4aa49fbc32: [native_rust_library] create User Keys backup when restoring user.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup.rs

42 lines

identity/

28 lines

lib.rs

8 lines

Diff 46843

View Options

native/native_rust_library/src/backup.rs

View Options

native/native_rust_library/src/identity/login.rs

View Options

native/native_rust_library/src/lib.rs

[native_rust_library] create User Keys backup when restoring userClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46843

native/native_rust_library/src/backup.rs

native/native_rust_library/src/identity/login.rs

native/native_rust_library/src/lib.rs

[native_rust_library] create User Keys backup when restoring user
ClosedPublic
Actions

Revision Contents
Changeset List