Details
Details
- Reviewers
bartek tomek - Commits
- rCOMM761c72a0602b: [SQLite] implement setting User Data keys
Tested later in the stack
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 3175–3176 ↗ | (On Diff #46838) | Not sure if it's relevant, but this PRAGMA can be executed only after PRAGMA key was executed. Should we validate that it is executed only when SQLiteQueryExecutor::backupDataKey and SQLiteQueryExecutor::backupLogDataKey are set? Or maybe we don't need to do that... |
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 3175–3176 ↗ | (On Diff #46838) | PRAGMA key is executed when SQLiteQueryExecutor instance is created and it is not possible to execute this code when key is not set, but it worth additionally check whether keys are set - at least in case of issue we'll get a better logging |