Paths

Table of Contentst

-
lib/
-
ops/
-
dm-operations-store-ops.js
-
shared/redux/
-
redux/
-
client-db-utils.js

[lib] Convert the operations
ClosedPublic
Actions

Authored by tomek on Mon, Mar 17, 6:59 AM.

Details

Reviewers

kamil
bartek

Commits

rCOMM413e95d152c6: [lib] Convert the operations

Summary

Add a conversion between DB and client types.

https://linear.app/comm/issue/ENG-10331/modify-the-reducer-to-support-the-db-operations

Depends on D14451

Test Plan

Tested the whole stack on both native and web:

Run the app on Redux version 86 with a modification to processDMOperation making all the INBOUND messages unsupported
On one platform created a thread and sent a text message. These were visible on the sender, and invisible on the recipient
Closed the recipient and added a migration that unshimms the thread creation operations, e.g.

unshimDMOperations(
  state,
  dmOperationTypes.CREATE_THREAD,
  handleReduxMigrationFailure,
): MigrationFunction<WebNavInfo, AppState>),

Run the recipient and noticed the thread appearing
Added another migration, this time unshimming text messages
Run the recipient and noticed messages appearing

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Mon, Mar 17, 6:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Mar 17, 6:59 AM

tomek added a child revision: D14453: [lib] Handle ops in the reducer.Mon, Mar 17, 7:02 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Mar 17, 7:22 AM

Harbormaster failed remote builds in B33728: Diff 47417!

Rebase

Harbormaster completed remote builds in B33755: Diff 47445.Tue, Mar 18, 4:03 AM

tomek requested review of this revision.Tue, Mar 18, 4:03 AM

kamil accepted this revision.Tue, Mar 18, 7:47 AM

This revision is now accepted and ready to land.Tue, Mar 18, 7:47 AM

Closed by commit rCOMM413e95d152c6: [lib] Convert the operations (authored by tomek). · Explain WhyWed, Mar 19, 9:57 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM413e95d152c6: [lib] Convert the operations.

Revision Contents
Changeset List

Path

Size

lib/

ops/

dm-operations-store-ops.js

25 lines

shared/

redux/

client-db-utils.js

5 lines

Diff 47445

View Options

lib/ops/dm-operations-store-ops.js

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines	[
identityClient,		identityClient,
primaryDeviceRequestedLogOut,		primaryDeviceRequestedLogOut,
],		],
);		);
}		}

function usePeerToPeerMessageHandler(): (		function usePeerToPeerMessageHandler(): (
message: PeerToPeerMessage,		message: PeerToPeerMessage,
messageID: string,
) => Promise<void> {		) => Promise<void> {
const { olmAPI, sqliteAPI } = getConfig();		const { olmAPI, sqliteAPI } = getConfig();

const identityContext = React.useContext(IdentityClientContext);		const identityContext = React.useContext(IdentityClientContext);
invariant(identityContext, 'Identity context should be set');		invariant(identityContext, 'Identity context should be set');
const { identityClient, getAuthMetadata } = identityContext;		const { identityClient, getAuthMetadata } = identityContext;

const foreignPeerDevices = useSelector(getForeignPeerDevices);		const foreignPeerDevices = useSelector(getForeignPeerDevices);
const broadcastDeviceListUpdates = useBroadcastDeviceListUpdates();		const broadcastDeviceListUpdates = useBroadcastDeviceListUpdates();
const getAndUpdateDeviceListsForUsers = useGetAndUpdateDeviceListsForUsers();		const getAndUpdateDeviceListsForUsers = useGetAndUpdateDeviceListsForUsers();

const handleOlmMessageToDevice = useHandleOlmMessageToDevice();		const handleOlmMessageToDevice = useHandleOlmMessageToDevice();

return React.useCallback(		return React.useCallback(
async (message: PeerToPeerMessage, messageID: string) => {		async (message: PeerToPeerMessage) => {
if (message.type === peerToPeerMessageTypes.OUTBOUND_SESSION_CREATION) {		if (message.type === peerToPeerMessageTypes.OUTBOUND_SESSION_CREATION) {
const { senderInfo, encryptedData, sessionVersion } = message;		const { senderInfo, encryptedData, sessionVersion } = message;
const { userID: senderUserID, deviceID: senderDeviceID } = senderInfo;		const { userID: senderUserID, deviceID: senderDeviceID } = senderInfo;

let deviceKeys: ?DeviceOlmInboundKeys = null;		let deviceKeys: ?DeviceOlmInboundKeys = null;
try {		try {
const { keys } =		const { keys } =
await identityClient.getInboundKeysForUser(senderUserID);		await identityClient.getInboundKeysForUser(senderUserID);
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines	async (message: PeerToPeerMessage) => {
`${senderDeviceID}: ${e.message}, ` +		`${senderDeviceID}: ${e.message}, ` +
`session version: ${sessionVersion}`,		`session version: ${sessionVersion}`,
);		);
}		}
}		}
} else if (message.type === peerToPeerMessageTypes.ENCRYPTED_MESSAGE) {		} else if (message.type === peerToPeerMessageTypes.ENCRYPTED_MESSAGE) {
try {		try {
await olmAPI.initializeCryptoAccount();		await olmAPI.initializeCryptoAccount();
const decrypted = await olmAPI.decryptSequentialAndPersist(		const decrypted = await olmAPI.decrypt(
message.encryptedData,		message.encryptedData,
message.senderInfo.deviceID,		message.senderInfo.deviceID,
messageID,
);		);
console.log(		console.log(
'Decrypted message from device ' +		'Decrypted message from device ' +
`${message.senderInfo.deviceID}: ${decrypted}`,		`${message.senderInfo.deviceID}: ${decrypted}`,
);		);

try {		try {
await handleOlmMessageToDevice(decrypted, message.senderInfo);		await handleOlmMessageToDevice(decrypted, message.senderInfo);
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines