Details
Details
- Reviewers
bartek tomek - Commits
- rCOMM9b236c2fc817: [lib] implement sending Farcaster requests
Tested using some local tests (with mocked DC token and user ID), it was also tested with client changes in the actual app, example here.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- farcaster-mvp-land
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 62–73 ↗ | (On Diff #49499) | Previously promise was just resolving without returning value, and it is not that easy to use the same map because of type differences |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 90–97 ↗ | (On Diff #49499) | Note that $Diff is deprecated in latest Flow - https://flow.org/en/docs/types/utilities/#toc-diff Not sure who lands first but this will have to be addressed: type SendFarcasterRequestPayload = Omit< FarcasterAPIRequest, 'type' | 'requestID' | 'userID', >; cc @angelika |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 403 ↗ | (On Diff #49499) | Nit: I guess response.data is a string. I'm wondering if we should wrap these with an error object, to avoid further confusions like https://phab.comm.dev/D15095?id=49145#inline-81973 |