Parse the message
Depends on
D15269
Details
Details
- Reviewers
bartek kamil - Commits
- rCOMM7edd42eebb44: [tunnelbroker] Parse Farcaster messages
Tested later in the stack
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| shared/tunnelbroker_messages/src/messages/farcaster.rs | ||
|---|---|---|
| 64 | We're putting these types here because in the next diff they will be sent to clients | |
| services/tunnelbroker/src/token_distributor/token_connection.rs | ||
|---|---|---|
| 127–128 | thanks for fixing that | |
| shared/tunnelbroker_messages/src/messages/farcaster.rs | ||
| 146 | I would try to type this too, maybe something like: #[derive(Serialize, Deserialize, Debug, PartialEq)]
#[serde(rename_all = "camelCase")]
pub enum MessageType {
RefreshDirectCastConversation,
RefreshSelfDirectCastsInbox,
Unseen,
#[serde(other)] // handles any unknown variants
Unknown,
}should work? This could improve readability and avoid hardcoded strings, but up to you | |
| shared/tunnelbroker_messages/src/messages/farcaster.rs | ||
|---|---|---|
| 103–123 ↗ | (On Diff #50115) | Nice |