Page MenuHomePhabricator

[CommCoreModule] Introduce `CommCoreModule::clearNotifyToken`
ClosedPublic

Authored by atul on Feb 10 2022, 6:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 11:58 PM
Unknown Object (File)
Sun, Nov 10, 11:58 PM
Unknown Object (File)
Sun, Nov 10, 11:58 PM
Unknown Object (File)
Sun, Nov 10, 11:11 PM
Unknown Object (File)
Fri, Nov 8, 12:40 PM
Unknown Object (File)
Fri, Nov 8, 12:40 PM
Unknown Object (File)
Fri, Nov 8, 12:40 PM
Unknown Object (File)
Fri, Nov 8, 12:40 PM

Details

Summary

Clears notifyToken from the SQLite metadata table.

Test Plan
  1. Add notifyToken entry to the metadata table
  2. Call global.CommCoreModule.clearNotifyToken()
  3. Ensure that the entry has been deleted: https://blob.sh/atul/709c.png

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Feb 10 2022, 6:31 PM

@atul, you've gotten into a "default mode" of adding me as a reviewer to your diffs when you create them. That was meant as a short-term fix to get your Tunnelbroker work out ASAP, but at this point that work has dragged on for weeks. This isn't meant to be a new default, so let's get back to the consistent, disciplined approach of having a first round of review before passing it to me

This revision is now accepted and ready to land.Feb 11 2022, 2:38 AM
This revision now requires review to proceed.Feb 11 2022, 2:38 AM
ashoat added a reviewer: jim.
This revision is now accepted and ready to land.Feb 13 2022, 8:10 PM