As we decided to store pickling key and pickled olm account instead of keys, olm_config structure and dev env set up needed to be updated.
Details
Details
No need to test those changes.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| docs/dev_environment.md | ||
|---|---|---|
| 567 ↗ | (On Diff #9700) | This not so random - we should rather say that this an encrypted / pickled data. But I'm wondering if it still makes sense to have this file structure here. We can instead explain that the script will generate a file for us. |
Comment Actions
Remove olm_config.json file structure from dev env setup instructions as it is no longer needed.
| docs/dev_environment.md | ||
|---|---|---|
| 562 ↗ | (On Diff #9761) | Let's say "This script" instead of "The script" |
Comment Actions
The relationship between this diff, D3053, and D3209 is not made clear. Please specify the dependency graph by hitting "Edit Related Revisions" in the UI above, or by having the text "Depends on: Dsomething" in either the diff description or a diff comment
Comment Actions
Please do NOT land without addressing the inline comment
| docs/dev_environment.md | ||
|---|---|---|
| 562 ↗ | (On Diff #9816) |
|
Comment Actions
Fix language inaccuracies.
| docs/dev_environment.md | ||
|---|---|---|
| 562 ↗ | (On Diff #9816) | I addressed those problems with changes introduced. |