Page MenuHomePhabricator
Differential D3211

Reflect script implementation in olm-utils and dev env setup instructions
ClosedPublic
Actions

Authored by marcin on Feb 15 2022, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 11:11 PM
Unknown Object (File)
Thu, Oct 17, 7:26 PM
Unknown Object (File)
Thu, Oct 17, 7:26 PM
Unknown Object (File)
Thu, Oct 17, 7:26 PM
Unknown Object (File)
Thu, Oct 17, 7:26 PM
Unknown Object (File)
Thu, Oct 17, 7:26 PM
Unknown Object (File)
Thu, Oct 17, 7:13 PM
Unknown Object (File)
Oct 4 2024, 7:13 AM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
• karol

Details

Reviewers
tomek
varun
ashoat
Commits
rCOMMe71fef283ad9: Reflect script implementation in olm-utils and dev env setup instructions
Summary

As we decided to store pickling key and pickled olm account instead of keys, olm_config structure and dev env set up needed to be updated.

Test Plan

No need to test those changes.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-582
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Feb 15 2022, 1:01 PM
Herald added subscribers: • karol, atul, • adrian, ashoat. · View Herald TranscriptFeb 15 2022, 1:01 PM
Harbormaster completed remote builds in B6854: Diff 9700.Feb 15 2022, 1:06 PM
marcin requested review of this revision.Feb 15 2022, 1:06 PM
tomek requested changes to this revision.Feb 16 2022, 7:09 AM
tomek added inline comments.
docs/dev_environment.md
567 ↗(On Diff #9700)

This not so random - we should rather say that this an encrypted / pickled data. But I'm wondering if it still makes sense to have this file structure here. We can instead explain that the script will generate a file for us.

This revision now requires changes to proceed.Feb 16 2022, 7:09 AM
marcin updated this revision to Diff 9761.Feb 17 2022, 2:46 AM

Remove olm_config.json file structure from dev env setup instructions as it is no longer needed.

Harbormaster completed remote builds in B6909: Diff 9761.Feb 17 2022, 2:51 AM
tomek accepted this revision.Feb 17 2022, 4:08 AM
This revision is now accepted and ready to land.Feb 17 2022, 4:08 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 17 2022, 4:08 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 17 2022, 4:08 AM
ashoat accepted this revision.Feb 22 2022, 12:01 AM
ashoat added inline comments.
docs/dev_environment.md
562 ↗(On Diff #9761)

Let's say "This script" instead of "The script"

This revision is now accepted and ready to land.Feb 22 2022, 12:01 AM
ashoat mentioned this in D3209: Implement script to generate olm configuration JSON file for keyserver.Feb 22 2022, 12:04 AM

The relationship between this diff, D3053, and D3209 is not made clear. Please specify the dependency graph by hitting "Edit Related Revisions" in the UI above, or by having the text "Depends on: Dsomething" in either the diff description or a diff comment

marcin added a parent revision: D3209: Implement script to generate olm configuration JSON file for keyserver.Feb 22 2022, 1:42 AM
marcin updated this revision to Diff 9816.Feb 22 2022, 6:06 AM

Use 'This script' instead of 'The script' for better language quality.

Harbormaster completed remote builds in B6956: Diff 9816.Feb 22 2022, 6:10 AM
ashoat accepted this revision.Feb 22 2022, 7:10 PM

Please do NOT land without addressing the inline comment

docs/dev_environment.md
562 ↗(On Diff #9816)
  1. "secrets directory" is ambiguous – not clear where it is exists
  2. You're missing the word "the" in a couple places
marcin updated this revision to Diff 9829.Feb 23 2022, 3:03 AM

Fix language inaccuracies.

docs/dev_environment.md
562 ↗(On Diff #9816)

I addressed those problems with changes introduced.

Harbormaster completed remote builds in B6965: Diff 9829.Feb 23 2022, 3:11 AM
ashoat accepted this revision.Feb 23 2022, 11:18 AM
Closed by commit rCOMMe71fef283ad9: Reflect script implementation in olm-utils and dev env setup instructions (authored by marcin). · Explain WhyFeb 23 2022, 11:59 PM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMe71fef283ad9: Reflect script implementation in olm-utils and dev env setup instructions.

Revision Contents
Changeset List

PathSize
docs/
10 lines
server/
src/
utils/
3 lines

Diff 9829

View Options

docs/dev_environment.md

Loading...
View Options

server/src/utils/olm-utils.js

Loading...