[web] Remove `background.png` from `Splash` and rename to `placeholder.png`
ClosedPublic
Actions

Authored by atul on Mar 16 2022, 2:40 PM.

Details

Reviewers

• jacek
tomek
varun
• benschac
ashoat

Commits

rCOMM4e40cf337478: [web] Remove `background.png` from `Splash` and rename to `placeholder.png`

Summary

Here's how it looks:

depends on D3445

Test Plan

Did a search for "images/background.png" and found no other occurences.

Then did a search for "background.png" and found that we were actually using it in sanitization.js to replace image URLs as part of the "sanitization process." So I renamed background.png to placeholder.png and left the file in.

Diff Detail

Repository

rCOMM Comm

Branch

landmarch16 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 16 2022, 2:40 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 16 2022, 2:40 PM

atul edited the summary of this revision. (Show Details)Mar 16 2022, 2:40 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B7432: Diff 10462.Mar 16 2022, 2:45 PM

atul requested review of this revision.Mar 16 2022, 2:45 PM

• benschac added inline comments.Mar 16 2022, 5:38 PM

lib/utils/sanitization.js
126 ↗	(On Diff #10462)	Can we replace the placeholder image? Is pretty ugly and doesn't match with anything.

atul edited the summary of this revision. (Show Details)Mar 16 2022, 9:10 PM

atul added a parent revision: D3445: [web] Remove `div.devices` and associated assets from `Splash` component.

atul added a child revision: D3447: [web] Remove "Request Access" markup/styling from `Splash` component.

Weird, not super clear why we're using it for sanitization but okay

This revision is now accepted and ready to land.Mar 16 2022, 9:16 PM

ashoat added inline comments.Mar 16 2022, 9:17 PM

lib/utils/sanitization.js
126 ↗	(On Diff #10462)	It's not actually used for anything, not sure it makes sense to slow down @atul for this. It's just for the sanitization process, eg. we replace actual images with this placeholder image when we make crash reports. Users never see it

In D3446#93678, @ashoat wrote:

Weird, not super clear why we're using it for sanitization but okay

It's for when we load crash reports via Redux DevTools. We wanted to replace the contents of image messages with some sort of placeholder image and we went with this since it happened to be in the repo. It could really be anything?

rebase before landing

This revision was landed with ongoing or failed builds.Mar 16 2022, 9:41 PM

Closed by commit rCOMM4e40cf337478: [web] Remove `background.png` from `Splash` and rename to `placeholder.png` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4e40cf337478: [web] Remove `background.png` from `Splash` and rename to `placeholder.png`.

Harbormaster completed remote builds in B7441: Diff 10473.Mar 16 2022, 9:47 PM