Page MenuHomePhabricator
Differential D3479

[web] Use SWM Icons in `Menu` component
ClosedPublic
Actions

Authored by • jacek on Mar 21 2022, 12:12 PM.
Tags
None
Referenced Files
F3393093: D3479.diff
Sat, Nov 30, 11:30 AM
Unknown Object (File)
Wed, Nov 27, 4:51 PM
Unknown Object (File)
Wed, Nov 27, 4:41 PM
Unknown Object (File)
Wed, Nov 27, 4:28 PM
Unknown Object (File)
Thu, Nov 7, 12:52 PM
Unknown Object (File)
Tue, Nov 5, 8:31 PM
Unknown Object (File)
Tue, Nov 5, 8:30 PM
Unknown Object (File)
Tue, Nov 5, 8:30 PM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
• karol

Details

Reviewers
tomek
• benschac
atul
Commits
rCOMM32e90a2be054: [web] Use SWM Icons in `Menu` component
Summary

Replace FontAwesome icons with correct ones from SWM Icon Pack (following Figma design)

Screenshot_Google Chrome_2022-03-21_201325.png (231×188 px, 9 KB)

Test Plan

Run web app and check if icons are correct in thread actions menu and members actions menu in members modal.

Diff Detail

Repository
rCOMM Comm
Branch
jacek/members-7
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Mar 21 2022, 12:12 PM
Herald added subscribers: • benschac, • karol, atul and 2 others. · View Herald TranscriptMar 21 2022, 12:12 PM
• jacek edited the summary of this revision. (Show Details)Mar 21 2022, 12:13 PM
• jacek added reviewers: • benschac, atul.
Harbormaster completed remote builds in B7512: Diff 10576.Mar 21 2022, 12:17 PM
• jacek requested review of this revision.Mar 21 2022, 12:17 PM
tomek accepted this revision.Mar 22 2022, 4:14 AM
tomek added inline comments.
web/components/menu-item.react.js
25 ↗(On Diff #10576)

Where is promptIcon defined? I can't find it in ./menu.css

This revision is now accepted and ready to land.Mar 22 2022, 4:14 AM
• jacek updated this revision to Diff 10594.Mar 22 2022, 5:18 AM

removed redundant css class

Harbormaster completed remote builds in B7528: Diff 10594.Mar 22 2022, 5:25 AM
• jacek added inline comments.Mar 22 2022, 5:30 AM
web/components/menu-item.react.js
25 ↗(On Diff #10576)

It was accidentally added while creating thread menu. I removed it

• jacek added a parent revision: D3385: [web] Introduce `Members` action in thread menu.Mar 22 2022, 10:40 AM
• jacek updated this revision to Diff 10872.Mar 31 2022, 2:30 AM

rebase

Harbormaster completed remote builds in B7756: Diff 10872.Mar 31 2022, 4:23 AM
Closed by commit rCOMM32e90a2be054: [web] Use SWM Icons in `Menu` component (authored by • jacek). · Explain WhyApr 1 2022, 3:51 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM32e90a2be054: [web] Use SWM Icons in `Menu` component.

Revision Contents
Changeset List

PathSize
web/
chat/
23 lines
components/
7 lines
8 lines
modals/
threads/
members/
11 lines

Diff 10594

View Options

web/chat/thread-menu.react.js

Loading...
View Options

web/components/menu-item.react.js

Loading...
View Options

web/components/menu.css

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...