[lib] New action to fetch single message for a list of threads
ClosedPublic
Actions

Authored by ashoat on Mar 30 2022, 8:29 AM.

Details

Reviewers

• jacek

Commits

rCOMM8c887ebc7fb9: [lib] New action to fetch single message for a list of threads

Summary

Needed to fetch messages for message previews

Test Plan

@def-au1t promised to help test this :)

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/fetch_message_preview

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 30 2022, 8:29 AM

Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptMar 30 2022, 8:29 AM

For consistency, rename SimpleMessagesResponse to SimpleMessagesPayload. For types that are only used in action paylods, it's better to use the term "Payload". "Response" indicates this type is used by the server when responding to clients, which is not true in this case.

Harbormaster completed remote builds in B7721: Diff 10823.Mar 30 2022, 8:36 AM

Harbormaster completed remote builds in B7722: Diff 10824.Mar 30 2022, 8:43 AM

ashoat requested review of this revision.Mar 30 2022, 8:43 AM

• jacek added a child revision: D3601: [web] Fetch preview messages from non-watched threads in thread subchannels modal.Apr 1 2022, 7:47 AM

I tested it in "Thread subchannels" modal and the action seems to work correctly

• jacek accepted this revision.Apr 4 2022, 10:36 AM

This revision is now accepted and ready to land.Apr 4 2022, 10:36 AM

Rebase

Thanks for helping test this, @def-au1t!

This revision was landed with ongoing or failed builds.Apr 6 2022, 2:08 PM

Closed by commit rCOMM8c887ebc7fb9: [lib] New action to fetch single message for a list of threads (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.