[services] Tunnelbroker - Move tools to the scope.
ClosedPublic
Actions

Authored by • max on Mar 31 2022, 5:33 AM.

Details

Reviewers

• karol
tomek
varun

Commits

rCOMM0ef828469c0a: [services] Tunnelbroker - Move tools to the scope.

Summary

Our 'tools' functions now reside in Tools.h,.cpp as a global scope which is not a good practice and will lead to functions confusion. The Tools functions must reside in their own tools namespace scope.

Linear task: ENG-958

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.

Diff Detail

Repository

rCOMM Comm

Branch

tools-to-scope

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Mar 31 2022, 5:33 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptMar 31 2022, 5:34 AM

• max edited the summary of this revision. (Show Details)Mar 31 2022, 5:34 AM

• max added reviewers: • karol, tomek, varun.

Harbormaster completed remote builds in B7759: Diff 10875.Mar 31 2022, 5:40 AM

• max requested review of this revision.Mar 31 2022, 5:40 AM

Are we going to do the same for other services?

This revision is now accepted and ready to land.Mar 31 2022, 8:44 AM

In D3581#97843, @palys-swm wrote:

Are we going to do the same for other services?

@karol-bisztyga what do you think? Should I create the task for blob and backup services?

In D3581#98754, @geekbrother wrote:

In D3581#97843, @palys-swm wrote:

Are we going to do the same for other services?

@karol-bisztyga what do you think? Should I create the task for blob and backup services?