Page MenuHomePhabricator
Differential D3581

[services] Tunnelbroker - Move tools to the scope.
ClosedPublic
Actions

Authored by • max on Mar 31 2022, 5:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 4:12 AM
Unknown Object (File)
Mon, Mar 31, 12:33 AM
Unknown Object (File)
Feb 14 2025, 10:27 AM
Unknown Object (File)
Jan 28 2025, 5:55 PM
Unknown Object (File)
Jan 27 2025, 11:44 PM
Unknown Object (File)
Jan 27 2025, 6:26 PM
Unknown Object (File)
Jan 18 2025, 5:10 PM
Unknown Object (File)
Jan 18 2025, 5:10 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
varun
Commits
rCOMM0ef828469c0a: [services] Tunnelbroker - Move tools to the scope.
Summary

Our 'tools' functions now reside in Tools.h,.cpp as a global scope which is not a good practice and will lead to functions confusion. The Tools functions must reside in their own tools namespace scope.

Linear task: ENG-958

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Mar 31 2022, 5:33 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptMar 31 2022, 5:34 AM
• max edited the summary of this revision. (Show Details)Mar 31 2022, 5:34 AM
• max added reviewers: • karol, tomek, varun.
Harbormaster completed remote builds in B7759: Diff 10875.Mar 31 2022, 5:40 AM
• max requested review of this revision.Mar 31 2022, 5:40 AM
tomek accepted this revision.Mar 31 2022, 8:44 AM

Are we going to do the same for other services?

This revision is now accepted and ready to land.Mar 31 2022, 8:44 AM
• max added a comment.Apr 4 2022, 7:31 AM
In D3581#97843, @palys-swm wrote:

Are we going to do the same for other services?

@karol-bisztyga what do you think? Should I create the task for blob and backup services?

• max added a comment.Apr 6 2022, 1:40 AM
In D3581#98754, @geekbrother wrote:
In D3581#97843, @palys-swm wrote:

Are we going to do the same for other services?

@karol-bisztyga what do you think? Should I create the task for blob and backup services?

Landing this and raised https://linear.app/comm/issue/ENG-976/move-services-tools-to-its-scope task for other services.

• max updated this revision to Diff 11091.Apr 6 2022, 4:33 AM

Rebase on master.

This revision was landed with ongoing or failed builds.Apr 6 2022, 4:36 AM
Closed by commit rCOMM0ef828469c0a: [services] Tunnelbroker - Move tools to the scope. (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM0ef828469c0a: [services] Tunnelbroker - Move tools to the scope..
Harbormaster completed remote builds in B7912: Diff 11091.Apr 6 2022, 4:40 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Amqp/
2 lines
Service/
13 lines
Tools/
2 lines
2 lines

Diff 11092

View Options

services/tunnelbroker/src/Amqp/AmqpManager.cpp

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
COPY --chown=comm desktop/package.json desktop/ COPY --chown=comm desktop/package.json desktop/
COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \ COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
COPY --chown=comm native/expo-modules/android-lifecycle/package.json \
native/expo-modules/android-lifecycle/
# Create empty Rust library and copy in Cargo.toml file # Create empty Rust library and copy in Cargo.toml file
RUN cargo init keyserver/addons/opaque-ke-napi --lib RUN cargo init keyserver/addons/opaque-ke-napi --lib
COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \ COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
# Copy in files needed for patch-package # Copy in files needed for patch-package
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.cpp

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
COPY --chown=comm desktop/package.json desktop/ COPY --chown=comm desktop/package.json desktop/
COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \ COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
COPY --chown=comm native/expo-modules/android-lifecycle/package.json \
native/expo-modules/android-lifecycle/
# Create empty Rust library and copy in Cargo.toml file # Create empty Rust library and copy in Cargo.toml file
RUN cargo init keyserver/addons/opaque-ke-napi --lib RUN cargo init keyserver/addons/opaque-ke-napi --lib
COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \ COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
# Copy in files needed for patch-package # Copy in files needed for patch-package
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/Tools/Tools.h

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
COPY --chown=comm desktop/package.json desktop/ COPY --chown=comm desktop/package.json desktop/
COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \ COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
COPY --chown=comm native/expo-modules/android-lifecycle/package.json \
native/expo-modules/android-lifecycle/
# Create empty Rust library and copy in Cargo.toml file # Create empty Rust library and copy in Cargo.toml file
RUN cargo init keyserver/addons/opaque-ke-napi --lib RUN cargo init keyserver/addons/opaque-ke-napi --lib
COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \ COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
# Copy in files needed for patch-package # Copy in files needed for patch-package
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/Tools/Tools.cpp

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
COPY --chown=comm desktop/package.json desktop/ COPY --chown=comm desktop/package.json desktop/
COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \ COPY --chown=comm keyserver/addons/opaque-ke-napi/package.json \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
COPY --chown=comm native/expo-modules/android-lifecycle/package.json \
native/expo-modules/android-lifecycle/
# Create empty Rust library and copy in Cargo.toml file # Create empty Rust library and copy in Cargo.toml file
RUN cargo init keyserver/addons/opaque-ke-napi --lib RUN cargo init keyserver/addons/opaque-ke-napi --lib
COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \ COPY --chown=comm keyserver/addons/opaque-ke-napi/Cargo.toml \
keyserver/addons/opaque-ke-napi/ keyserver/addons/opaque-ke-napi/
# Copy in files needed for patch-package # Copy in files needed for patch-package
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines