[services] Tunnelbroker - Move tools to the scope.
ClosedPublic
Actions

Authored by • max on Mar 31 2022, 5:33 AM.

Details

Reviewers

• karol
tomek
varun

Commits

rCOMM0ef828469c0a: [services] Tunnelbroker - Move tools to the scope.

Summary

Our 'tools' functions now reside in Tools.h,.cpp as a global scope which is not a good practice and will lead to functions confusion. The Tools functions must reside in their own tools namespace scope.

Linear task: ENG-958

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.

Diff Detail

Repository

rCOMM Comm

Branch

tools-to-scope

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Mar 31 2022, 5:33 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptMar 31 2022, 5:34 AM

• max edited the summary of this revision. (Show Details)Mar 31 2022, 5:34 AM

• max added reviewers: • karol, tomek, varun.

Harbormaster completed remote builds in B7759: Diff 10875.Mar 31 2022, 5:40 AM

• max requested review of this revision.Mar 31 2022, 5:40 AM

Are we going to do the same for other services?

This revision is now accepted and ready to land.Mar 31 2022, 8:44 AM

In D3581#97843, @palys-swm wrote:

Are we going to do the same for other services?

@karol-bisztyga what do you think? Should I create the task for blob and backup services?

In D3581#98754, @geekbrother wrote:

In D3581#97843, @palys-swm wrote:

Are we going to do the same for other services?

@karol-bisztyga what do you think? Should I create the task for blob and backup services?

Landing this and raised https://linear.app/comm/issue/ENG-976/move-services-tools-to-its-scope task for other services.

Rebase on master.

This revision was landed with ongoing or failed builds.Apr 6 2022, 4:36 AM

Closed by commit rCOMM0ef828469c0a: [services] Tunnelbroker - Move tools to the scope. (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM0ef828469c0a: [services] Tunnelbroker - Move tools to the scope..

Harbormaster completed remote builds in B7912: Diff 11091.Apr 6 2022, 4:40 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Amqp/

AmqpManager.cpp

2 lines

Service/

TunnelbrokerServiceImpl.cpp

13 lines

Tools/

Tools.h

2 lines

Tools.cpp

2 lines

Diff 11091

View Options

services/tunnelbroker/src/Amqp/AmqpManager.cpp

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.cpp

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

services/tunnelbroker/src/Tools/Tools.h

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

services/tunnelbroker/src/Tools/Tools.cpp

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

[services] Tunnelbroker - Move tools to the scope.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11091

services/tunnelbroker/src/Amqp/AmqpManager.cpp

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.cpp

services/tunnelbroker/src/Tools/Tools.h

services/tunnelbroker/src/Tools/Tools.cpp

[services] Tunnelbroker - Move tools to the scope.
ClosedPublic
Actions

Revision Contents
Changeset List