Paths

Table of Contentst

Differential D3597

[web] [lib] Introduce `getMessagePreview` function
ClosedPublic
Actions

Authored by • jacek on Apr 1 2022, 7:19 AM.

Tags

None

Referenced Files

	F3486332: D3597.diff
	Wed, Dec 18, 4:32 AM

	Unknown Object (File)
	Nov 16 2024, 10:21 PM

	Unknown Object (File)
	Nov 10 2024, 1:03 AM

	Unknown Object (File)
	Nov 9 2024, 11:13 PM

	Unknown Object (File)
	Nov 9 2024, 9:16 PM

	Unknown Object (File)
	Nov 9 2024, 8:28 PM

	Unknown Object (File)
	Nov 9 2024, 8:28 PM

	Unknown Object (File)
	Nov 9 2024, 4:02 PM

Subscribers

Details

Reviewers

tomek
• benschac
atul

Commits

rCOMM8c2d50500131: [web] [lib] Introduce `getMessagePreview` function

Summary

Moved logic for displaying message preview data into common function, to reuse it in modal with subchannels list.
No logic changes has been made.

Test Plan

In web app, message previews in chat list should display exactly as before.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Apr 1 2022, 7:19 AM

Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptApr 1 2022, 7:19 AM

Harbormaster completed remote builds in B7795: Diff 10956.Apr 1 2022, 7:26 AM

• jacek requested review of this revision.Apr 1 2022, 7:26 AM

• jacek added reviewers: • benschac, atul.Apr 1 2022, 7:38 AM

• jacek added a child revision: D3599: [web] Introduce `Subchannel` component.Apr 1 2022, 7:48 AM

tomek requested changes to this revision.Apr 4 2022, 2:05 AM

tomek added inline comments.

lib/hooks/message-preview.js
7–12 ↗	(On Diff #10956)	We can probably merge these
20 ↗	(On Diff #10956)	We're not using hooks inside it, so maybe this can be a plain function instead of a hook?
25–27 ↗	(On Diff #10956)	We could introduce a different return type that represents no messages and use this in `message-preview` instead of checking `if (!originalMessageInfo) {`. This value can probably be just null.

This revision now requires changes to proceed.Apr 4 2022, 2:05 AM

tomek mentioned this in D3599: [web] Introduce `Subchannel` component.Apr 4 2022, 2:28 AM

Changed the hook into plain function

• jacek retitled this revision from [web] [lib] Introduce `useMessagePreview` hook to [web] [lib] Introduce `getMessagePreview` function.Apr 4 2022, 6:18 AM

• jacek edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B7824: Diff 10991!Apr 4 2022, 6:20 AM

tomek accepted this revision.Apr 5 2022, 7:01 AM

tomek added inline comments.

lib/hooks/message-preview.js
25–27 ↗	(On Diff #10956)	What do you think about this idea?

This revision is now accepted and ready to land.Apr 5 2022, 7:01 AM

• jacek added inline comments.Apr 8 2022, 2:10 AM

lib/hooks/message-preview.js
25–27 ↗	(On Diff #10956)	I think the idea is no longer valid, as after changing the hook into function, I execute it conditionally and message info is always present.

rebase

Harbormaster completed remote builds in B8007: Diff 11212.Apr 8 2022, 2:27 AM

Closed by commit rCOMM8c2d50500131: [web] [lib] Introduce `getMessagePreview` function (authored by • jacek). · Explain WhyApr 8 2022, 7:09 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM8c2d50500131: [web] [lib] Introduce `getMessagePreview` function.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

31 lines

web/

chat/

message-preview.react.js

29 lines

Diff 10991

lib/shared/message-utils.js

Loading...

web/chat/message-preview.react.js

Loading...