Page MenuHomePhabricator

[services] Tunnelbroker - Remove SessionItem method.
ClosedPublic

Authored by max on Apr 6 2022, 11:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 23, 10:54 AM
Unknown Object (File)
Thu, Sep 19, 3:17 AM
Unknown Object (File)
Tue, Sep 10, 8:51 PM
Unknown Object (File)
Tue, Sep 10, 8:51 PM
Unknown Object (File)
Tue, Sep 10, 8:51 PM
Unknown Object (File)
Tue, Sep 10, 8:50 PM
Unknown Object (File)
Tue, Sep 10, 8:46 PM
Unknown Object (File)
Sat, Sep 7, 4:21 AM

Details

Summary

We don't have a database method to remove the SessionItem, because there was no need to remove it explicitly. The item record is removed by the DynamoDB TTL. We don't have any device "logout" for implementing the remove method and removing it explicitly from the tunnelbroker side.

Now we need to remove the SessionItem record from the database explicitly in tests (we'll insert, check and remove).

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.
SessionItem record was removed by the SessionID key.

Diff Detail

Repository
rCOMM Comm
Branch
sessionitem-remove
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max edited the test plan for this revision. (Show Details)
max added reviewers: karol, tomek, varun.

Small diff with descriptive and clear summary - good work!

This revision is now accepted and ready to land.Apr 7 2022, 11:41 PM
This revision was landed with ongoing or failed builds.Apr 11 2022, 2:15 AM
This revision was automatically updated to reflect the committed changes.