Paths

Table of Contentst

-
services/tunnelbroker/src/Database/
-
tunnelbroker/
-
src/
-
Database/
1/1
DatabaseManager.h
1/1
DatabaseManager.cpp

[services] Tunnelbroker - Remove SessionItem method.
ClosedPublic
Actions

Authored by • max on Apr 6 2022, 11:25 PM.

Details

Reviewers

• karol
tomek
varun

Commits

rCOMM4b00b849220e: [services] Tunnelbroker - Remove SessionItem method.

Summary

We don't have a database method to remove the SessionItem, because there was no need to remove it explicitly. The item record is removed by the DynamoDB TTL. We don't have any device "logout" for implementing the remove method and removing it explicitly from the tunnelbroker side.

Now we need to remove the SessionItem record from the database explicitly in tests (we'll insert, check and remove).

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.
SessionItem record was removed by the SessionID key.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D3641

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Apr 6 2022, 11:25 PM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 6 2022, 11:25 PM

• max edited the summary of this revision. (Show Details)Apr 6 2022, 11:26 PM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, tomek, varun.

Harbormaster completed remote builds in B7944: Diff 11133.Apr 6 2022, 11:33 PM

• max requested review of this revision.Apr 6 2022, 11:33 PM

• max added a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.Apr 7 2022, 3:22 AM

• max removed a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.

• max added a child revision: D3643: [services] Tunnelbroker - Database item tests initialization.

• karol accepted this revision.Apr 7 2022, 3:46 AM

Small diff with descriptive and clear summary - good work!

This revision is now accepted and ready to land.Apr 7 2022, 11:41 PM

Rebase on master.

This revision was landed with ongoing or failed builds.Apr 11 2022, 2:15 AM

Closed by commit rCOMM4b00b849220e: [services] Tunnelbroker - Remove SessionItem method. (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM4b00b849220e: [services] Tunnelbroker - Remove SessionItem method..

Harbormaster completed remote builds in B8052: Diff 11270.Apr 11 2022, 2:21 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Database/

DatabaseManager.h

1 line

DatabaseManager.cpp

4 lines

Diff 11270

View Options

services/tunnelbroker/src/Database/DatabaseManager.h

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines	"dependencies": {
"sharp": "^0.30.5",		"sharp": "^0.30.5",
"siwe": "^1.1.6",		"siwe": "^1.1.6",
"sql-template-strings": "^2.2.2",		"sql-template-strings": "^2.2.2",
"stream-combiner": "^0.2.2",		"stream-combiner": "^0.2.2",
"tcomb": "^3.2.29",		"tcomb": "^3.2.29",
"twin-bcrypt": "^2.1.1",		"twin-bcrypt": "^2.1.1",
"uuid": "^3.3.3",		"uuid": "^3.3.3",
"web": "0.0.1",		"web": "0.0.1",
"web-push": "^3.5.0"		"web-push": "^3.5.0",
		"ws": "^8.13.0"
		ashoatUnsubmitted Done Inline Actions Realizing this will change the version of `ws` that is imported here. In fact we're already importing a newer version (7.5.9) than our version of `express-ws` uses (5.2.3), but it looks like we only use it for Flow types so it's okay ashoat: Realizing this will change the version of `ws` that is imported [here](https://github.
},		},
"optionalDependencies": {		"optionalDependencies": {
"bufferutil": "^4.0.5",		"bufferutil": "^4.0.5",
"utf-8-validate": "^5.0.7"		"utf-8-validate": "^5.0.7"
},		},
"nodemonConfig": {		"nodemonConfig": {
"delay": "200"		"delay": "200"
},		},
Show All 15 Lines