[lib] Make relationship update function dependent on user id
ClosedPublic
Actions

Authored by tomek on Apr 14 2022, 11:40 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM2687a805fb3b: [lib] Make relationship update function dependent on user id

Summary

We don't need to depend on the whole user info and instead can depend only on the id.
This is the first step of extracting a hook that provides functions that manipulate relationships.

Test Plan

It shouldn't change the behavior but still tested it by sending friend request on native and checking if the state was updated.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 14 2022, 11:40 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 14 2022, 11:40 AM

tomek added a child revision: D3733: [lib] Delete extraneous invariant and dependency from relationship change callback.Apr 14 2022, 11:41 AM

Harbormaster completed remote builds in B8210: Diff 11481.Apr 14 2022, 11:45 AM

tomek requested review of this revision.Apr 14 2022, 11:45 AM

Makes sense, wonder if we can make a similar change to the onButtonPress callback (on line 66) as well?

edit: lol jk looks like that's handled in D3733

This revision is now accepted and ready to land.Apr 14 2022, 5:31 PM

Closed by commit rCOMM2687a805fb3b: [lib] Make relationship update function dependent on user id (authored by tomek). · Explain WhyApr 15 2022, 2:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM2687a805fb3b: [lib] Make relationship update function dependent on user id.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

relationship-prompt.js

4 lines

Diff 11504

View Options

lib/hooks/relationship-prompt.js

[lib] Make relationship update function dependent on user idClosedPublicActions