[lib] Introduce relationship callbacks
ClosedPublic
Actions

Authored by tomek on Apr 14 2022, 11:42 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM72aa035507f4: [lib] Introduce relationship callbacks

Summary

Create a hook that returns functions that modify the relationship. This hook depends only on userID and onErrorCallback so it's a lot more convenient to use.
Depends on D3733

Test Plan

Send friend request by using relationship prompt and check if the state was updated.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Apr 14 2022, 11:42 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 14 2022, 11:42 AM

tomek added a child revision: D3735: [lib] Fix memoization of useRelationshipPrompt.Apr 14 2022, 11:43 AM

Harbormaster completed remote builds in B8212: Diff 11483.Apr 14 2022, 11:50 AM

tomek requested review of this revision.Apr 14 2022, 11:50 AM

atul accepted this revision.Apr 14 2022, 6:26 PM

atul added inline comments.

lib/hooks/relationship-prompt.js
62	Should we maybe name this `otherUserID?`

This revision is now accepted and ready to land.Apr 14 2022, 6:26 PM

tomek added inline comments.Apr 15 2022, 1:55 AM

lib/hooks/relationship-prompt.js
62	Makes sense!

Rename

This revision was landed with ongoing or failed builds.Apr 15 2022, 2:16 AM

Closed by commit rCOMM72aa035507f4: [lib] Introduce relationship callbacks (authored by tomek). · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM72aa035507f4: [lib] Introduce relationship callbacks.

Harbormaster completed remote builds in B8224: Diff 11498.Apr 15 2022, 8:16 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

relationship-prompt.js

48 lines

Diff 11483

View Options

lib/hooks/relationship-prompt.js

[lib] Introduce relationship callbacksClosedPublicActions