Page MenuHomePhabricator
Differential D3770

[web] Move `hasPermissionForTab` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 18 2022, 3:41 PM.
Tags
None
Referenced Files
F3572196: D3770.diff
Sat, Dec 28, 11:12 AM
Unknown Object (File)
Wed, Dec 25, 12:53 PM
Unknown Object (File)
Wed, Dec 25, 12:53 PM
Unknown Object (File)
Wed, Dec 25, 12:53 PM
Unknown Object (File)
Wed, Dec 25, 12:53 PM
Unknown Object (File)
Wed, Dec 25, 12:52 PM
Unknown Object (File)
Wed, Dec 25, 12:50 PM
Unknown Object (File)
Nov 22 2024, 2:01 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMM99e225d4681a: [web] Move `hasPermissionForTab` up from `ThreadSettingsModal` to…
Summary

Move hasPermissionForTab up from ThreadSettingsModal to ConnectedThreadSettingsModal.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.

Depends on D3769

Test Plan
  1. Open ThreadSettingsModal for a few threads
  2. Ensure that the expected tabs are visible based on permission

Diff Detail

Repository
rCOMM Comm
Branch
actuallylandapril21 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 18 2022, 3:41 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 18 2022, 3:41 PM
Harbormaster completed remote builds in B8283: Diff 11579.Apr 18 2022, 3:46 PM
atul requested review of this revision.Apr 18 2022, 3:46 PM
atul updated this revision to Diff 11651.Apr 19 2022, 3:05 PM

rebase

Harbormaster completed remote builds in B8341: Diff 11651.Apr 19 2022, 3:30 PM
atul added a child revision: D3783: [web] Move `deleteThreadAction` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 19 2022, 4:02 PM
tomek accepted this revision.Apr 21 2022, 3:12 AM
This revision is now accepted and ready to land.Apr 21 2022, 3:12 AM
atul updated this revision to Diff 11755.Apr 21 2022, 11:30 AM

rebase before landing

Harbormaster completed remote builds in B8424: Diff 11755.Apr 21 2022, 11:35 AM
Closed by commit rCOMM99e225d4681a: [web] Move `hasPermissionForTab` up from `ThreadSettingsModal` to… (authored by atul). · Explain WhyApr 21 2022, 11:35 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM99e225d4681a: [web] Move `hasPermissionForTab` up from `ThreadSettingsModal` to….

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
50 lines

Diff 11755

View Options

web/modals/threads/thread-settings-modal.react.js

Loading...