Page MenuHomePhabricator

[chore] [web] bump fortawesome in web directory
ClosedPublic

Authored by benschac on May 9 2022, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:36 AM
Unknown Object (File)
Mon, Nov 18, 11:29 AM
Unknown Object (File)
Wed, Nov 13, 10:50 AM
Unknown Object (File)
Sun, Nov 3, 2:36 PM
Unknown Object (File)
Sun, Nov 3, 2:36 PM
Unknown Object (File)
Sun, Nov 3, 2:36 PM
Unknown Object (File)
Sun, Nov 3, 2:33 PM
Unknown Object (File)
Oct 10 2024, 3:06 AM

Details

Summary

bump packages in web folder

Test Plan

open components like filter-panel.react that use the fortawesome icon package.

run yarn upgrade-interactive select @fortawesome packages in web

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benschac edited the test plan for this revision. (Show Details)

Didn't we already handle this in D3936?

We should make sure we keep the versions in sync across the yarn workspaces

This revision is now accepted and ready to land.May 10 2022, 6:49 AM

We should make sure we keep the versions in sync across the yarn workspaces

This is critical. If yarn upgrade-interactive doesn't make it easy to do this we should avoid using it. In general I'm a bit skeptical of tools like that, as I worry they hide complexity from the user that is necessary to understand in order to do the work well. I tend to simply edit yarn.lock and package.json files directory when I want something changed. I always try to go through all package.json files as well as all relevant entires in yarn.lock in order to look for inconsistencies

We should make sure we keep the versions in sync across the yarn workspaces

This is critical. If yarn upgrade-interactive doesn't make it easy to do this we should avoid using it. In general I'm a bit skeptical of tools like that, as I worry they hide complexity from the user that is necessary to understand in order to do the work well. I tend to simply edit yarn.lock and package.json files directory when I want something changed. I always try to go through all package.json files as well as all relevant entires in yarn.lock in order to look for inconsistencies

image.png (774×2 px, 268 KB)

I think it's pretty easy. The caveat is just to select all of the workspaces using the npm package when doing an update. Which I didn't do last time because I thought making the smallest possible change was the goal, and then testing in isolation. I can add this to the dev notes if that seems reasonable.

I think nobody reads Dev Notes, and I think you're the only one who uses yarn upgrade-interactive, so probably the only value of documenting is if it's useful for you