Differential D4169
[native] Fix `CommCoreModule:createMessageStoreOperations` for REMOVE_ALL_OPERATION Authored by atul on May 31 2022, 1:22 PM. Tags None Referenced Files
Details Before, we were trying to get payload_obj by calling getProperty(rt, "payload").asObject(rt) regardless of the op type. However, the REMOVE_ALL_OPERATION type doesn't have a payload which results in the call to getProperty(rt, "payload").asObject(rt) crashing the app. We weren't using the REMOVE_ALL_OPERATION anywhere before, but we are using it in redux migration 31 ("flipping on SQLite messageStore persistence") which is where the issue was surfaced. Ran redux migration 31 in my local dev environment and everything worked as expected. Set breakpoints in the C++ code to verify that things were as expected all along the way from the call to global.CommCoreModule.processMessageStoreOperationsSync(...).
Diff Detail
Event TimelineComment Actions @marcinwasowicz is probably a good person to review this because it has to do with C++ code in native Comment Actions True, I'll keep that in mind for C++ code in native going forward. Will also add @marcinwasowicz to any diffs related to "flipping the switch" since it's blocking his work. |