Page MenuHomePhabricator

[keyserver] Make it possible to run Comm web app without Apache proxying to it
ClosedPublic

Authored by ashoat on Jun 3 2022, 2:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 10:11 AM
Unknown Object (File)
Fri, Nov 8, 8:35 AM
Unknown Object (File)
Fri, Nov 8, 8:08 AM
Unknown Object (File)
Tue, Nov 5, 2:02 AM
Unknown Object (File)
Oct 18 2024, 5:35 PM
Unknown Object (File)
Oct 18 2024, 7:22 AM

Details

Summary

To avoid breaking anybody's environment, if the proxy config is left out, we'll continue defaulting to Apache.

This diff makes it easier to test things sometimes, and perhaps somebody will want to run the Web app without a proxy. (That said, we don't currently support HTTPS/TLS without a proxy, so it would probably be a bad idea to do that on production.)

Linear task: https://linear.app/comm/issue/ENG-1221/make-it-possible-to-run-node-without-apache

Test Plan

I tested a local environment proxied over Apache and a local environment without proxying. I did not test a local environment without proxying with HTTPS enabled, as this would require adding support for certificates to the Node server, which is out of scope

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable