Page MenuHomePhabricator

[keyserver] Avoid redownloading Node from nvm whenever any files change
ClosedPublic

Authored by ashoat on Jun 5 2022, 10:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 4:09 AM
Unknown Object (File)
Mon, Jan 6, 4:09 AM
Unknown Object (File)
Thu, Jan 2, 2:24 AM
Unknown Object (File)
Thu, Dec 26, 5:43 PM
Unknown Object (File)
Fri, Dec 20, 1:09 AM
Unknown Object (File)
Thu, Dec 19, 11:00 PM
Unknown Object (File)
Thu, Dec 19, 11:00 PM
Unknown Object (File)
Sun, Dec 15, 5:00 PM

Details

Summary

Since we don't download Node until the first time source-nvm.sh is run, that means Node gets downloaded in the prod-build step.

prod-build needs to rerun whenever any files change, but Node should only need to get downloaded when the version changes.

This diff uses Docker build caching to call source-nvm.sh earlier, so that we can make it cheaper to rebuild when a source file changes.

Depends on D4213

Test Plan

Change a file in keyserver/src and make sure that nvm doesn't re-download Node when running the Docker build again

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable