Page MenuHomePhabricator

[keyserver] Avoid redownloading Node from nvm whenever any files change
ClosedPublic

Authored by ashoat on Jun 5 2022, 10:22 PM.
Tags
None
Referenced Files
F3358091: D4214.diff
Sun, Nov 24, 3:27 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 8:08 AM
Unknown Object (File)
Tue, Nov 5, 2:01 AM
Unknown Object (File)
Sat, Nov 2, 9:38 AM
Unknown Object (File)
Oct 21 2024, 3:13 PM
Unknown Object (File)
Oct 21 2024, 6:31 AM

Details

Summary

Since we don't download Node until the first time source-nvm.sh is run, that means Node gets downloaded in the prod-build step.

prod-build needs to rerun whenever any files change, but Node should only need to get downloaded when the version changes.

This diff uses Docker build caching to call source-nvm.sh earlier, so that we can make it cheaper to rebuild when a source file changes.

Depends on D4213

Test Plan

Change a file in keyserver/src and make sure that nvm doesn't re-download Node when running the Docker build again

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable