Page MenuHomePhabricator

[keyserver] Avoid redownloading Node from nvm whenever any files change
ClosedPublic

Authored by ashoat on Jun 5 2022, 10:22 PM.
Tags
None
Referenced Files
F2190297: D4214.diff
Thu, Jul 4, 11:44 AM
F2188181: D4214.id13344.diff
Thu, Jul 4, 8:31 AM
F2188141: D4214.id13360.diff
Thu, Jul 4, 8:19 AM
F2181295: D4214.id.diff
Wed, Jul 3, 5:30 PM
F2179983: D4214.diff
Wed, Jul 3, 2:22 PM
Unknown Object (File)
Mon, Jun 17, 3:16 PM
Unknown Object (File)
Mon, Jun 17, 3:16 PM
Unknown Object (File)
Sun, Jun 16, 5:54 PM

Details

Summary

Since we don't download Node until the first time source-nvm.sh is run, that means Node gets downloaded in the prod-build step.

prod-build needs to rerun whenever any files change, but Node should only need to get downloaded when the version changes.

This diff uses Docker build caching to call source-nvm.sh earlier, so that we can make it cheaper to rebuild when a source file changes.

Depends on D4213

Test Plan

Change a file in keyserver/src and make sure that nvm doesn't re-download Node when running the Docker build again

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable